Skip to content

French strings match their English keys again; the two header/footer variants are translated - #455

Closed
prxnvt wants to merge 1 commit into
storytold:mainfrom
prxnvt:pr/fr-different-first-page
Closed

prxnvt wants to merge 1 commit into
storytold:mainfrom
prxnvt:pr/fr-different-first-page

Conversation

@prxnvt

@prxnvt prxnvt commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Overview

The French catalog from #413 has 109 entries, from "Insert Copied Cells" onward, whose text belongs to a different entry. A French user currently sees, for example:

Where English Shown in French on main Now
Data Show Detail Titre Afficher le détail
Data Solver Page web (.html) Solveur
Data Forecast Sheet Aller au pied de page Feuille de prévision
Data Data Analysis Description Analyse de données
Backstage Back Classeur vide Retour
Backstage Save Type de fichier Enregistrer
View Ruler Enregistrer sous Règle
Header & Footer Header Informations En-tête

Every entry is now the French for its own key, using the usual French spreadsheet terms. Keys and their order are unchanged.

"Different First Page" and "Different Odd & Even Pages" (added with #344) had no French entry, so i18n::tests::translations_are_unique_and_preserve_unknown_text fails on main with "missing French: Different First Page". Both are added, and the test passes.

fr-data-before fr-data fr-header-footer

Tests

  • The coverage test passes again. It also spot-checks a few of the corrected labels, so a shuffle like this one fails it.
  • Rendered offscreen in French (--language fr --tab Data): before and after screenshots attached.
  • cargo xtask ci: fmt, clippy, assets, layers, wasm, parity and keytips pass. Two engine tests fail on main independently of this PR (io::tests::csv_save_keeps_the_separator_it_was_opened_with and tests::saving_an_opened_semicolon_csv_keeps_semicolons: a 12-digit number in a CSV round trip comes back as 1.24412E+11). They fail the same way here.

A French speaker's review is welcome, particularly of the longer Backstage sentences.

…er/footer variants are translated (storytold#413)

From "Insert Copied Cells" on, 109 of the French entries had another
entry's text: Data showed "Titre" for Show Detail and "Page web (.html)"
for Solver, the Backstage showed "Classeur vide" for Back and "Type de
fichier" for Save, and the Insert, Review, Page Layout and header/footer
labels were shuffled the same way. Each is now the French for its own
key. "Different First Page" and "Different Odd & Even Pages", added to
the catalog with storytold#344, had no French yet, so the coverage test failed
on main; both are added.

The test spot-checks a few of the corrected labels.
@prxnvt

prxnvt commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #454, which covers the same corrections and also restores the two-line ribbon labels. One part of this pull request that may still be useful is the set of Language::Fr.tr(...) assertions added to translations_are_unique_and_preserve_unknown_text; they make the test fail if the French entries become misaligned again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant