Repository navigation
Conversation
…er/footer variants are translated (storytold#413) From "Insert Copied Cells" on, 109 of the French entries had another entry's text: Data showed "Titre" for Show Detail and "Page web (.html)" for Solver, the Backstage showed "Classeur vide" for Back and "Type de fichier" for Save, and the Insert, Review, Page Layout and header/footer labels were shuffled the same way. Each is now the French for its own key. "Different First Page" and "Different Odd & Even Pages", added to the catalog with storytold#344, had no French yet, so the coverage test failed on main; both are added. The test spot-checks a few of the corrected labels.
Contributor
Author
|
Closing in favor of #454, which covers the same corrections and also restores the two-line ribbon labels. One part of this pull request that may still be useful is the set of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The French catalog from #413 has 109 entries, from "Insert Copied Cells" onward, whose text belongs to a different entry. A French user currently sees, for example:
Every entry is now the French for its own key, using the usual French spreadsheet terms. Keys and their order are unchanged.
"Different First Page" and "Different Odd & Even Pages" (added with #344) had no French entry, so
i18n::tests::translations_are_unique_and_preserve_unknown_textfails on main with "missing French: Different First Page". Both are added, and the test passes.Tests
--language fr --tab Data): before and after screenshots attached.cargo xtask ci: fmt, clippy, assets, layers, wasm, parity and keytips pass. Two engine tests fail on main independently of this PR (io::tests::csv_save_keeps_the_separator_it_was_opened_withandtests::saving_an_opened_semicolon_csv_keeps_semicolons: a 12-digit number in a CSV round trip comes back as1.24412E+11). They fail the same way here.A French speaker's review is welcome, particularly of the longer Backstage sentences.