Repository navigation
Grid: deleting several Ctrl-selected rows removes them all (#758) - #766
Merged
Merged
Conversation
…#758) home.deleteRows/deleteColumns used only the last selected area. They now take every area (or a comma list like "3:3,7:8"), merge them and delete from the last to the first inside one edit, so it is one undo step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts: # ROADMAP.md # crates/engine/src/cmd/sheet.rs
Member
|
Merged — thank you @vangel76 for the contribution! I merged main into your branch and resolved the conflicts with PRs that landed first (and adjusted tests where the combination needed it). |
GhostMitra
added a commit
to GhostMitra/gridcraft
that referenced
this pull request
Oct 13, 2026
…d#766 parity) Desktop and web start on Backstage Home (Blank workbook, templates, Recent) when no file, --sample or --control is given; Esc/back leaves the empty blank workbook. File › Options › General › Start-up checkbox (ui.startScreen, kept between runs, default on). SheetApp::new is unchanged; hosts opt in via SheetApp::start_screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #758
Root cause
home.deleteRows/home.deleteColumnsresolved their target withlines(), which reads onlyselection.current()(the last area). With Ctrl-selected rows the header-menu Delete therefore removed just the last one.What changed
crates/engine/src/cmd/sheet.rs: newdelete_areas()collects every selected area (or a comma list such as"3:3,7:8"inrows/cols), merges overlapping/adjacent ones and orders them last-to-first.delete_lineschecks sheet protection for each area, then deletes them all inside a singleedit, so it is one undo step. An explicitcountkeeps the old single-area behaviour. The UI is untouched: the header menu already keeps the multi-selection and calls the command with empty params.ROADMAP.md: progress row and revision row.Tests / commands run
deleting_a_multi_area_row_selection_removes_every_area_and_undoes_once(rows 2, 4, 5:6 via selection; formula becomes#REF!; one undo restores all; list form for columns).cargo test -p gridcraft-engine --lib(230 passed),cargo clippy -p gridcraft-engine --all-targets -- -D warnings,cargo fmt -p gridcraft-engine.Not done
home.insertRows/home.insertColumnsstill use only the last area (not changed; Insert is a different semantic, left out).xtask cirun (CI covers it).🤖 Generated with Claude Code