Repository navigation
Conversation
…erences (#900, #877, #872, #873, #875) - A press selects its cell when the button goes down and a drag extends from it; Shift/Ctrl act on the press; checkboxes and links act on the click; the selection border, a selected column header, objects and Page Layout headers/footers wait for the drag or click (#900). - Double-clicking the fill handle fills down to the bottom of the data region around the source, stopping above the first filled cell under it: new `edit.autoFillToData`, tested against 13 cases observed in Excel (#877). The old double-click handler was never reached. - While typing a formula, column and row headings point `B:B`, `B:D`, `3:3` into it (#872); whole-column and whole-row references are coloured and outlined (#873, #875); F4 toggles them `$B:$D` / `B:D` as Excel does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 23, 2026
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Brandon
Before: a cell was selected only when the mouse button came back up, and a press that moved a little inside the cell could select nothing (#900). Double-clicking the fill handle used the left column only and missed data on the right or reached diagonally (#877). Clicking a heading while typing a formula inserted
B:Bbut couldn't be dragged toB:D, whole-column and whole-row references (A:A,2:2) were neither coloured nor outlined (#873, #875), and F4 mangled them into$A$:$A$.After: the press selects at once and a drag extends from it, as in Excel. Shift and Ctrl act on the press, while checkboxes and links act on the click. Double-clicking the fill handle fills to the bottom of the data region around the source and stops above a filled cell, matching 13 layouts observed in Excel for Windows. Headings point
B:B,B:Dor3:3into a formula, and those references get their own colour, an outline on the grid, and F4 toggling$B:$D⇄B:D(#872, #873, #875).How:
grid::interactnow acts onprimary_pressed, with apress_consumedflag so the press's drag start or click doesn't act again. Targets that are buttons or may turn into another drag (the outline band, the selection border, a selected column heading, objects, Page Layout headers and footers) defer to the drag start or the click. Newedit.autoFillToDatacommand (selection::fill_down_extent, built oncurrent_region_of) visits only stored cells, so tall sheets stay fast.Drag::PointLineshandles heading drags in point mode, replacingpoint_headerfrom #691.formula_refsrecognises whole-line references, and the F4 logic moved tocycle_ref.Tests:
ui-egui/tests/press_select.rs(11 UI tests through real egui input, 4 of which fail on the old code), Excel-observed fill cases inengine/src/tests.rs, and unit tests for reference spans and F4.fill_handle_double_click.rsfrom #507 still passes and now counts the new command. Fuzzer wired. Workspace tests, wasm and fmt pass. Clippy on Rust 1.95 flags pre-existing lints inxlsx/src/xls/mod.rs,xlsx/src/tests/passthrough_tests.rsandgrid.rs:2592(none touched here); with those allowed, the changed crates are clean.Closes #900, closes #877, closes #872, closes #873, closes #875.
🤖 Generated with Claude Code