assert.InEpsilonSlice doesn't append custom error message

[bushkov]

Bug summary

When InEpsilonSlice takes a custom error message and the assertion fails, the custom message isn't displayed.

The issue is that in InEpsilonSlice implementation, msgAndArgs isn't passed to InEpsilon when iterating over slice elements:

testify/assert/assertions.go

Line 1366 in 0ab3ce1

result := InEpsilon(t, actualSlice.Index(i).Interface(), expectedSlice.Index(i).Interface(), epsilon)

It should be:

result := InEpsilon(t, actualSlice.Index(i).Interface(), expectedSlice.Index(i).Interface(), epsilon, msgAndArgs...)

To reproduce

Write any test where InEpsilonSlice fails and takes a custom message. The message wouldn't be displayed.

[dolmen]

Here is a reproducer: https://go.dev/play/p/E-lLwVrMXym

[myusko]

Is an issue still relevant? I see mentions in the #1483 PR that was merged.

cc @arjunmahishi

[brackendawson]

The custom error message is still not shown, this issue is valid.

[arjunmahishi]

I've addressed it in #1548 along with the http assertions