Conversation
ccoVeille
previously approved these changes
Apr 8, 2026
dolmen
force-pushed
the
dolmen/mock-replace-objx.Map-1852
branch
from
May 6, 2026 08:29
aa3233d to
89f7ac6
Compare
Collaborator
Author
Collaborator
Author
|
@brackendawson Following your comment on #1757, what is your stance regarding finally removing |
In order to ease maintenance of downstream forks of Testify that would remove dependency on github.com/stretchr/objx we move all uses of that module in isolated source files. A fork without that dependency could just remove those files. See #1752 (comment) The use of objx is quite contained: it is only used in Mock.TestData(). Note that we can't just remove that method or change the return value because that would be a breaking change.
Add build tag testify_no_objx to allow to exclude method Mock.TestData() for avoiding dependency on github.com/stretchr/objx.
Drop the last reference to dependency github.com/stretchr/objx. Reference to objx.Map is removed (BREAKING CHANGE) from the Mock.TestData method signature. A similar object is returned instead of objx.Map, but we do not aim to implement the full objx.Value API: instead we expose the reflect.Value API that should help enough the few users of Mock.TestData to move away from objx.Map reliance. Implemented as planned in #1852.
dolmen
force-pushed
the
dolmen/mock-replace-objx.Map-1852
branch
from
May 14, 2026 17:37
89f7ac6 to
d6431e8
Compare
brackendawson
requested changes
Jun 9, 2026
brackendawson
left a comment
brackendawson
left a comment
Collaborator
There was a problem hiding this comment.
This change requires a major version bump. No ifs, no buts.
| // TestData holds any data that might be useful for testing. Testify ignores | ||
| // this data completely allowing you to do whatever you like with it. | ||
| testData objx.Map | ||
| testData testData |
Collaborator
There was a problem hiding this comment.
This is a breaking change:
package kata_test
import (
"testing"
"github.com/stretchr/objx"
"github.com/stretchr/testify/mock"
)
func TestIfy(t *testing.T) {
m := &mock.Mock{}
var td objx.Map
td = m.TestData()
td.Set("selector", "value")
}
Collaborator
Author
There was a problem hiding this comment.
Yes, this is a breaking change, as mentionned both in the commit message and in the description of this PR, and this has been discussed here: #1852 (comment). There is no other way forward to drop the objx dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix use of
objx.Mapin the signature ofmock.Mock.TestData().Drop
github.com/stretchr/objxdependency.This implements proposal #1852.
Changes
go mod tidyremoves the dependencyMotivation
This allows to drop the dependency on the objx module.
Benefits:
testify/mockpackageRelated issues
Closes #1852