Skip to content

test: wait for popstate state updates #16954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svelte-triage-bot wants to merge 1 commit into from
Closed

test: wait for popstate state updates #16954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/kit/test/apps/basics/src/routes/shallow-routing/push-state/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,5 @@
</span>
<span data-id="resolved">{resolved}</span>
<span data-id="now">{data.now}</span>
<span data-id="search" hidden>{page.shallow?.url.search ?? page.url.search}</span>
<div style="height: 2000px"></div>
5 changes: 5 additions & 0 deletions packages/kit/test/apps/basics/test/client.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@
await expect(page.locator('[data-testid="scores"]')).toHaveText('2 - 2');
});

test('refreshAll finishing before navigation ends does not prevent navigation', async ({

Check warning on line 909 in packages/kit/test/apps/basics/test/client.test.js

View workflow job for this annotation

GitHub Actions / e2e (test:svelte-async:build, js, 1/2)

flaky test: refreshAll finishing before navigation ends does not prevent navigation 

retries: 2
page,
clicknav
}) => {
Expand Down Expand Up @@ -1399,7 +1399,7 @@
await expect(page.locator('[data-testid="order"]')).toHaveText('afterNavigate,restore');
});

test('captures and restores function snapshots', async ({ page, clicknav }) => {

Check warning on line 1402 in packages/kit/test/apps/basics/test/client.test.js

View workflow job for this annotation

GitHub Actions / e2e (test:server-side-route-resolution:build, js, 1/2)

flaky test: captures and restores function snapshots 

retries: 2
await page.goto('/snapshot/helper');
await page.locator('[data-testid="default"]').fill('default value');
await page.locator('[data-testid="manual"]').fill('manual value');
Expand Down Expand Up @@ -2309,6 +2309,7 @@
for (const shallow of [true, false]) {
const prefix = shallow ? 'shallow' : 'regular';
const input = page.locator('[data-id="options-focus"]');
const search = page.locator('[data-id="search"]');
const state = () =>
page.evaluate(() => ({
focus: document.activeElement?.getAttribute('data-id') ?? document.activeElement?.tagName,
Expand All @@ -2325,23 +2326,27 @@
await page.evaluate(() => scrollTo(0, 700));
await page.goBack();
await expect(page).not.toHaveURL(new RegExp(`${prefix}=a`));
await expect(search).toHaveText('');
await expect.poll(state).toEqual({ focus: 'options-focus', y: 700 });

await page.evaluate(() => scrollTo(0, 300));
await page.goForward();
await expect(page).toHaveURL(new RegExp(`${prefix}=a`));
await expect(search).toHaveText(`?${prefix}=a`);
await expect.poll(state).toEqual({ focus: 'options-focus', y: 300 });

await page.reload();
await input.focus();
await page.evaluate(() => scrollTo(0, 350));
await page.goBack();
await expect(page).not.toHaveURL(new RegExp(`${prefix}=a`));
await expect(search).toHaveText('');
await expect.poll(state).toEqual({ focus: 'options-focus', y: 350 });

await page.evaluate(() => scrollTo(0, 400));
await page.goForward();
await expect(page).toHaveURL(new RegExp(`${prefix}=a`));
await expect(search).toHaveText(`?${prefix}=a`);
await expect.poll(state).toEqual({ focus: 'options-focus', y: 400 });

await app.goto(`?${prefix}=b`, { shallow, reset: true });
Expand Down
Loading