Repository navigation
chore: hand adapt-time values to the adapter-node server as a module - #17103
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d797bf0884dbd730839bc73a01e8ead27baef0daOpen in |
🦋 Changeset detectedLatest commit: d797bf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4000bc7 to
a9fde96
Compare
a9fde96 to
49b99e5
Compare
|
I investigated this failed test run, but the investigation came up empty. What I tried
This is an intermittent browser/Playwright worker-teardown failure, not a deterministic SvelteKit regression or a failed assertion. The job's decisive error was an unattributed 45-second worker teardown timeout; the three named tests were retry victims that attempted to create contexts after their worker browser had closed, and all passed on retry. The same mechanism reproduced on the unchanged base, while failures moved among unrelated tests under parallel load. It is consistent with known browser-process shutdown failures discussed in microsoft/playwright#39753 and branded-browser worker failures in microsoft/playwright#28601. Browser-selection and stronger page-cleanup experiments improved focused stress runs but did not survive the full CI-shaped suite, so no defensible standalone repository fix could be verified. The workspace was restored clean at the trusted base, and nothing was committed or pushed. |
#17068 injects the values
adaptlearns after the Vite build by regex-patching stub identifiers in the built chunks and remapping their sourcemaps.Now
adaptwrites them tobuild/adapter-node.jsand the chunks import it. No chunk is edited after Vite writes it, and the adapter has no runtime dependencies.