Repository navigation
fix: support bare Node built-ins and .wasm/font files in Netlify edge functions - #17324
Merged
Merged
Conversation
… functions The migration from esbuild to rolldown (#15432) regressed two cases in the edge function bundle: - `resolve.alias` rewrites `crypto` to `node:crypto`, but rolldown then tries to resolve `node:crypto` itself and errors before `external` is checked. Replace the alias with a `resolveId` plugin that marks it external. - The esbuild `copy` loaders for `.wasm` and font files were dropped, so rolldown tried to parse them as JS. Restore them via `moduleTypes`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/931571d894928daccbc4df12bd6bfd8e20c22d3fOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 931571d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
added
pkg:adapter-netlify
needs-platform-tests
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Member
|
Test failures are related to the Netlify CLI rather than the change itself. Verified manually |
teemingc
approved these changes
Oct 5, 2026
teemingc
left a comment
teemingc
left a comment
Member
There was a problem hiding this comment.
Thank you! I made a small tweak by replacing the custom plugin with specifying platform: 'node' instead (this is what Netlify's edge bundler does)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17323
Fixes two regressions from the esbuild → rolldown migration (#15432) in the Netlify edge function bundle:
resolve.aliasfor Node built-ins with a smallresolveIdplugin. With the alias, rolldown tries to resolvenode:cryptoitself and errors beforeexternalis checked.copyloaders for.wasmand font files viamoduleTypes.Adds a bare
cryptoimport and a.wasmimport (via a local test dependency) to theedgetest app, with build tests that fail without this change. I also ran the built edge function in Deno 2.9 to confirm both routes work.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits
🤖 Generated with Claude Code