Repository navigation
fix: allow resolve() inside remote queries when paths.relative is true - #17359
Open
tiagovilasboas wants to merge 2 commits into
Open
tiagovilasboas wants to merge 2 commits into
tiagovilasboas wants to merge 2 commits into
Conversation
Relative prefixes read event.url, which queries forbid. Query results are cached across pages, so fall back to an absolute base + resolved path. Co-authored-by: Tiago Vilas Boas <tcarvalhovb@gmail.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/53faf2fc2b9b2241da666166188124abdebff766Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 53faf2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17357
With the default
paths.relative: true,resolve()from$app/pathsreadsevent.urlto compute a relative prefix. Remote queries forbid that access (#16452), so callingresolve()inside aquerythrows:A relative prefix is also incorrect in a query: results are cached across pages, so the path cannot depend on whichever page first invoked it.
This change skips the relative-prefix path when
state.is_in_remote_queryis set and falls back tobase + resolved.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits