Skip to content

🍒[cxx-interop] Lower iOS deployment target for Cxx and CxxStdlib - #77979

Merged
egorzhdan merged 1 commit into
release/6.1from
egorzhdan/6.1-cxx-ios-deployment-target
Dec 5, 2024
Merged

egorzhdan merged 1 commit into
release/6.1from
egorzhdan/6.1-cxx-ios-deployment-target

Conversation

@egorzhdan

Copy link
Copy Markdown
Contributor

Explanation: The iOS/watchOS/tvOS deployment targets for Cxx and CxxStdlib binaries got unintentionally bumped in b87b263, which is causing build failures when trying to back-deploy Swift libraries. This reverts the deployment targets to the older versions.
Scope: Changes the CMake build script for Cxx and CxxStdlib targets.
Risk: Low, this only affects two C++ interop overlay modules, and it only brings back the pre-6.0.2 behavior.
Issue: rdar://140823785 / resolves #77909
Reviewer: @DougGregor @Xazax-hun @drodriguez

Original PR: #77921

The iOS/watchOS/tvOS deployment targets for Cxx and CxxStdlib binaries got unintentionally bumped in b87b263.

This reverts the deployment targets to the older versions.

rdar://140823785 / resolves #77909
(cherry picked from commit 22141b1)
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Dec 5, 2024
@egorzhdan
egorzhdan requested a review from a team as a code owner December 5, 2024 13:42
@egorzhdan

Copy link
Copy Markdown
Contributor Author

@swift-ci please test

@mrousavy

Copy link
Copy Markdown
Contributor

Hey thanks for fixing this!

I'm a bit confused as of releases - did this PR go into Xcode 16.2.?

I just upgraded my Xcode to 16.2. and my builds failed since I use the C++ interop:

- Compiling for iOS 15.1, but module 'CxxStdlib' has a minimum deployment target of iOS 16.0: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/CxxStdlib.swiftmodule/arm64-apple-ios-simulator.swiftmodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ interop Feature: Interoperability with C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants