Repository navigation
Strip only a trailing .git from GitHub repository names - #93
Open
breken (breken-ai) wants to merge 1 commit into
Open
breken (breken-ai) wants to merge 1 commit into
breken (breken-ai) wants to merge 1 commit into
Conversation
parse_github_url removed ".git" wherever it appeared in the name, so https://github.com/octocat/octocat.github.io became octocat/octocathub.io and the clone failed. Any repository whose name contains .git (GitHub Pages sites, .github profile repositories) could not be indexed by URL.
|
breken (@breken-ai) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitClient.parse_github_urlremoved.gitwherever it appeared in the repository name, not only as a suffix. A name that contains.gitcame out mangled, so the clone asked GitHub for a repository that does not exist:That covers every GitHub Pages site (
<user>.github.io) and every.githubprofile repository. BothIndexingService.index_repositoryand the indexing worker parse the pasted URL through this method, so indexing any of them by URL failed at the clone step. Theowner/reposhorthand was not affected, because it never goes through the replace.The fix is
removesuffix(".git"), sohttps://github.com/octocat/octocat.github.io.gitstill normalises to the same URL as the form without the suffix.test_parse_github_url_strips_only_a_trailing_git_suffixinbackend/tests/test_git_client.pyfails onmaster(octocathub.io) and passes with the change.test_git_client.pyandtest_indexing_worker.pypass, and ruff and mypy are clean.🤖 Generated with Claude Code