Repository navigation
fix(cli): treat --port=N as an explicitly passed port - #795
Merged
Ishaan Gangwani (ishaan1124) merged 2 commits intoSep 29, 2026
Merged
Ishaan Gangwani (ishaan1124) merged 2 commits into
Ishaan Gangwani (ishaan1124) merged 2 commits into
Conversation
ANIRUDDHA ADAK (aniruddhaadak80)
requested review from
Aayam Bansal (aayambansal) and
Ishaan Gangwani (ishaan1124)
as code owners
September 28, 2026 15:51
|
ANIRUDDHA ADAK (@aniruddhaadak80) is attempting to deploy a commit to the InkVell Team on Vercel. A member of the Team first needs to authorize it. |
ANIRUDDHA ADAK (aniruddhaadak80)
force-pushed
the
fix/cli-explicit-port-flag
branch
from
September 29, 2026 04:49
16d6246 to
76c8e42
Compare
The detection matched only the bare word --port, so --port=5555 was parsed by yargs into the same argument but never counted as passed, and server.port from the config won silently.
ANIRUDDHA ADAK (aniruddhaadak80)
force-pushed
the
fix/cli-explicit-port-flag
branch
from
September 29, 2026 10:02
76c8e42 to
79f10d5
Compare
# Conflicts: # CHANGELOG.md
Ishaan Gangwani (ishaan1124)
merged commit Sep 29, 2026
cab7657
into
synthetic-sciences:main
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
resolveNetworkOptionsdecided whether a port was passed with an exact string match:Why it matters
yargs parses
--port 5555and--port=5555into the sameargs.port. The argument is right either way; what differs is whether the flag that decides to trust it over the config file. So withserver.portinopenscience.json:The
=form is the more common spelling in scripts, CI, and docs snippets, so the port a user explicitly typed is discarded and the server binds somewhere they did not ask for — with no warning, and a clean startup that reads as the flag having been honoured.Verification
New file —
src/cli/network.tshad no unit test at all. Fails before, passes after:Both spellings are pinned side by side, plus the two fallback paths and the existing CORS merge, so the precedence rule is now fully covered.
The change
bun run typecheckclean; touched files are Prettier-clean (checked on LF-normalized copies — this checkout hascore.autocrlf=true, which makes Prettier flag every file in the repo).Fixes #794