Repository navigation
feat(command): implement Drop for CommandChild with kill_on_drop option - #3149
Merged
lucasfernog merged 7 commits intoOct 16, 2026
Merged
Conversation
Contributor
Author
|
CC @Legend-Master and @FabianLars |
Contributor
Package Changes Through afc6a20There are 4 changes which include deep-link with patch, deep-link-js with patch, shell with minor, single-instance with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
|
I don't mind adding this but it doesn't really sound like something related to the issues/PRs you linked? |
Contributor
Author
|
If more complex logic is introduced in the future, using drop(command) will make it easier to extend the data structures. No more external system tool need invoked. |
lucasfernog
reviewed
Oct 16, 2026
lucasfernog
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1332, tauri-apps/tauri#14443 tauri-apps/tauri#14360
Not totally resolved for these.
Simplfy impl Drop for CommandChild, only takes effect on tauri-plugin-shell, whether if it is sidecar or normal command. Taks advantage of rust's liftime control. Before the impl, drop has no any operation. Has no any additional external tool usage or invoke helper program. Competiable with tauri dev.
Usage: