Repository navigation
fix(updater): release the previous download when downloading again - #3691
Merged
lucasfernog merged 1 commit intoOct 11, 2026
Merged
Conversation
Each `Update.download()` overwrote `this.downloadedBytes` without closing the previous resource, so the whole previous update payload stayed in the webview resources table. The previous resource is now closed once the new download succeeded (so a failed retry still leaves the earlier download installable). Not covered by e2e: the fixture manifest has no valid signature, so a download can never succeed there. plugins/updater/guest-js/index.ts
Contributor
Package Changes Through 357e1d0There are 3 changes which include single-instance with patch, updater with patch, updater-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
Update.download()overwrotethis.downloadedByteswithout closing the previous resource, so the whole previous update payload stayed in the webview resources table. The previous resource is now closed once the new download succeeded (so a failed retry still leaves the earlier download installable).