Repository navigation
fix(core): correct asset protocol multi-range responses (fix: #15837) - #15838
Conversation
Package Changes Through 5bf4f8eThere are 14 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-build with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, @tauri-apps/api with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Hey @Legend-Master, could you review this fix for the asset protocol's multi-range responses? It's been open a month. |
amrbashir
left a comment
There was a problem hiding this comment.
Thank you. This LGTM, one small nit and could you also update examples/streaming/main.rs, it have the same issue.
94ad6e1 to
5bf4f8e
Compare
|
Done, re-signed all commits. |
Multi-range
asset://responses had three problems. The multipart body was terminated with an opening boundary (--boundary) instead of the close-delimiter RFC 2046 asks for (--boundary--). The sniffed file mime type set before the range branch stayed on the response alongsidemultipart/byteranges, becauseBuilder::headerappends rather than replaces, so clients reading the firstContent-Typeparsed the envelope as the file itself. And the status stayed200 OKwhile the body was partial.Single-range requests, which is what
<video>and<audio>normally send, were never affected, so this only shows up on clients asking for more than one range. Added a unit test covering all three.Closes #15837.