Skip to content

fix(bundler): recognize deb and rpm as self-contained updater targets - #16064

Merged
lucasfernog merged 4 commits into
devfrom
fix/bundler-updater-deb-rpm
Sep 25, 2026
Merged

lucasfernog merged 4 commits into
devfrom
fix/bundler-updater-deb-rpm

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

The self-contained updater check excluded RPM and the "no updater-enabled targets" warning omitted deb/rpm, although both are signed as updater artifacts and supported by the updater plugin.

The self-contained updater check excluded RPM and the "no updater-enabled targets" warning omitted deb/rpm, although both are signed as updater artifacts and supported by the updater plugin.
@lucasfernog
lucasfernog requested a review from a team as a code owner September 21, 2026 00:10
Comment thread crates/tauri-bundler/src/bundle.rs Resolved
Comment thread crates/tauri-bundler/src/bundle.rs Resolved
Comment thread crates/tauri-bundler/src/bundle.rs Outdated
}
}) {
// Targets the legacy v1 updater can consume once they are wrapped in a tar.gz / zip.
let has_v1_target = package_types.iter().any(|package_type| {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let has_v1_target = package_types.iter().any(|package_type| {
let has_v1_target = updater.v1_compatible && package_types.iter().any(|package_type| {

move the check here?

Comment thread crates/tauri-bundler/src/bundle.rs Outdated
log::warn!(
"No v1 compatible updater artifact was created: the legacy updater only supports the app, appimage, msi and nsis targets. deb and rpm bundles can only be installed by the v2 updater plugin."
);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then move this up to the else if branch above

@lucasfernog
lucasfernog merged commit 15468de into dev Sep 25, 2026
21 checks passed
@lucasfernog
lucasfernog deleted the fix/bundler-updater-deb-rpm branch September 25, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants