Repository navigation
fix(tray-icon): bump tray-icon to 0.25 and muda to 0.20 (fix #16035) - #16088
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
6f217e1 to
838b6ce
Compare
…ps#16035) tray-icon 0.24's macOS backend keeps the native NSMenu attached to the status item at all times via setMenu:, which on macOS 27 causes AppKit to swallow left-click events into its own menu-tracking before the crate's click-detection view ever sees them. tray-icon 0.25.1 (via tray-icon#365) fixes this by only attaching the menu while it's actually being presented. muda bumped alongside it to satisfy tray-icon 0.25.1's own `^0.20` requirement. Both crates renamed some feature flags in this range (tray-icon's `gtk`/`libxdo`/`common-controls-v6` now forward through `muda-gtk3`/`muda-libxdo`/`muda-common-controls-v6`; muda's own `gtk` became `gtk3`), updated here accordingly. Verified: `cargo check -p tauri --features tray-icon,common-controls-v6` and `--all-features` both build clean on macOS; `cargo test -p tauri --features tray-icon,common-controls-v6 --lib` passes all 70 tests. Linux gtk3/gtk4 and libxdo paths are unverified — no Linux environment available to test them.
838b6ce to
7662bc7
Compare
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| tauri: patch:deps | |||
There was a problem hiding this comment.
| tauri: patch:deps | |
| tauri: minor:bug |
Even though it is a dependency bump, I think it is appropriate to flag as bug fix in the changelog
Also because we have https://docs.rs/tauri/latest/tauri/tray/struct.TrayIcon.html#method.with_inner_tray_icon, we need to make this a minor release
Package Changes Through 4381cc8There are 14 changes which include tauri with minor, tauri-utils with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-build with minor, tauri-runtime with minor, tauri-runtime-wry with minor, @tauri-apps/api with minor, tauri-bundler with minor, tauri-codegen with minor, tauri-macos-sign with minor, tauri-macros with minor, tauri-plugin with minor, tauri-driver with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Summary
Closes #16035. Bumps
tray-iconfrom0.24to0.25andmudafrom0.19to0.20(required bytray-icon0.25.1's own^0.20constraint) to pick up tray-icon#365, which fixes left-click events on the tray icon being swallowed by the native menu on macOS 27.Root cause per the upstream fix: the macOS tray backend kept the
NSMenuattached to the status item viasetMenu:at all times. On macOS 27, AppKit started swallowing left-click events into its own menu-tracking before the crate's click-detection view ever received them. 0.25.1 fixes this by only attaching the menu while it's actually being presented.@amrbashir noted on #16035 that the fix "will be available in the next release" — this PR is the corresponding dependency bump, since
2.11.6shipped after that comment without it.Feature flag renames
Both crates renamed some feature flags in this version range:
tray-icon:gtk→ forwards tomuda-gtk3;libxdo→muda-libxdo;common-controls-v6→muda-common-controls-v6muda:gtk→gtk3(muda 0.20 added separategtk3/gtk4features)crates/tauri/Cargo.tomlis updated to match (gtk→gtk3for the directmudadep,gtk→muda-gtk3for thetray-icondep's forwarded feature, etc.), preserving the existing default behavior (gtk3-based Linux tray, libxdo enabled where it already was).Test plan
cargo check -p tauri --features tray-icon,common-controls-v6— clean build on macOScargo check -p tauri --all-features— clean build on macOScargo test -p tauri --features tray-icon,common-controls-v6 --lib— 70/70 tests pass, includingtests::aliased_features_existandtests::features_are_documentedCargo.tomls but the Linux tray backend itself wasn't exercised.