Repository navigation
feat: add external bin (sidecar) path resolver - #16265
lucasfernog wants to merge 2 commits into
Conversation
|
Awesome to see this land directly in core Tauri @lucasfernog! 🚀 The Since this was ported over from #3700, could you please add a |
| * | ||
| * @since 2.13.0 | ||
| */ | ||
| async function resolveSidecar(name: string): Promise<string> { |
There was a problem hiding this comment.
Since our config is externalBin, does it make sense to match it here?
There was a problem hiding this comment.
Both make a lot of sense! Historically developers know the concept as 'sidecar' from the guides and app.shell().sidecar(), but matching externalBin aligns directly with tauri.conf.json > bundle > externalBin.
Having resolveSidecar (or keeping one as an alias of resolveExternalBin) might give the best of both worlds for DX and discoverability. Happy to roll with whichever naming you and @lucasfernog prefer!
| })?; | ||
|
|
||
| // when running tests the executable is in the `deps` directory | ||
| let base_dir = if exe_dir.ends_with("deps") { |
There was a problem hiding this comment.
Maybe re-use our check from resource_dir_from?
tauri-apps/plugins-workspace#3700 replacement Co-authored-by: Karan Gupta <83299258+karan5028ji@users.noreply.github.com>
95a6265 to
6d6b686
Compare
tauri-apps/plugins-workspace#3700 replacement