Repository navigation
Normative: Add class static initialization blocks - #2440
Merged
Merged
Conversation
ljharb
added
needs test262 tests
jmdyck
requested changes
Jun 23, 2021
jmdyck
left a comment
jmdyck
left a comment
Collaborator
There was a problem hiding this comment.
Also, I believe the following SDO definitions are needed:
- EvaluateBody for ClassStaticBlockBody
- PrivateBoundIdentifiers for ClassStaticBlock
- ComputedPropertyContainsAwait for ClassStaticBlock
rbuckton
force-pushed
the
class-static-block
branch
2 times, most recently
from
June 24, 2021 20:19
1875a2e to
5319cfe
Compare
Member
Author
|
Thanks @jmdyck. I believe I've addressed your feedback, though I chose to use |
This was referenced Jun 24, 2021
jmdyck
previously requested changes
Jun 25, 2021
rbuckton
force-pushed
the
class-static-block
branch
from
June 28, 2021 20:40
5319cfe to
3c4fd9a
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
June 29, 2021 02:21
3d0c24c to
7a79833
Compare
Member
Author
|
@tc39/ecma262-editors would you be able to review this? |
jmdyck
reviewed
Aug 13, 2021
jmdyck
reviewed
Aug 13, 2021
Member
Author
|
SpiderMonkey intends to ship this unflagged in 93, and it is already shipping in V8. I'd like to seek Stage 4 at the upcoming meeting, assuming an editor review is complete and approved prior to the agenda submission deadline at the end of the week. |
bakkot
added
editor call
jmdyck
reviewed
Aug 18, 2021
rbuckton
force-pushed
the
class-static-block
branch
from
August 18, 2021 19:54
7a6936c to
6194172
Compare
syg
approved these changes
Aug 24, 2021
bakkot
reviewed
Aug 24, 2021
bakkot
approved these changes
Aug 24, 2021
bakkot
left a comment
bakkot
left a comment
Member
There was a problem hiding this comment.
LGTM apart from open comments.
rbuckton
force-pushed
the
class-static-block
branch
from
August 25, 2021 01:10
657f41e to
3a335f7
Compare
ljharb
added
has stage 4
35 of 36 tasks
bakkot
added
editor call
ljharb
pushed a commit
to rbuckton/ecma262
that referenced
this pull request
Sep 8, 2021
ljharb
force-pushed
the
class-static-block
branch
from
September 8, 2021 22:16
3a335f7 to
b51a822
Compare
ljharb
force-pushed
the
class-static-block
branch
from
September 8, 2021 22:17
b51a822 to
51e28c7
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the specification text from https://github.com/tc39/proposal-class-static-block, currently at Stage 3.