Skip to content

missing test property on compiled files #10

Closed

Description

@GiladShoham

When using both compiler and tester in bit, bit will send to the tester the compiled files.
In order for bit to know which compiled files consider test files the compiler should add dist=true prop on the returned vinyl files.
The current version of the typescript (3.0.35), react-typescript(3.0.27) and angular (0.2.0) compilers are missing this prop so the tester getting empty test files array.

Activity

  1. added a commit that references this issue on Nov 17, 2019
    c052ac7
  2. Mouvedia commented on May 22, 2020

    @Mouvedia

    Is bit.envs/compilers/stencil also affected?

  3. GiladShoham commented on Jun 2, 2020

    @GiladShoham
    MemberAuthor

    @Mouvedia By looking at the code, it might have the same bug.
    I would recommend open a new issue for this.
    @JoshK2 can you please verify it?

  4. JoshK2 commented on Jul 21, 2020

    @JoshK2
    Member

    I fixed this in the Stencil compiler and all the compiler that use the readFiles function from here:
    https://bit.dev/bit/envs/compilers/utils/~code#files.utils.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions