Repository navigation
import type #124
Description
Describe the bug
Using the statement import type { SomeType } from './Component.d.ts' throws a parsing error.
I'm not sure if this is related:
babel/babel#10981
Steps to Reproduce
- Use
import type { SomeType } from './Component.d.ts'
Expected Behavior
It should not throw any parsing errors as Typescript 3.8 supports this.
Screenshots, exceptions and logs
When running bit status you get a parsing error as if import type... is not valid synthax:
Same goes for when running bit build:
If applicable, add screenshots, exceptions, and logs to help explain your problem.
Specifications
- Bit version: 14.7.6
- Node version: 12.16.2
- npm / yarn version: 6.14.4
- Platform: Windows 10 x64
- Compiler / Tester (include version): react-typescript@3.1.51
Activity
Tallyb commentedon Apr 15, 2020
@GiladShoham - seems like Bit TS requires upgrading to 3.8
l0gicgate commentedon Apr 15, 2020
@Tallyb looks like you guys are already on 3.8.3 https://github.com/teambit/envs/blob/master/package.json#L63
But on the babel compiler package you’re on 3.6.2:
https://github.com/teambit/envs/blob/master/packages/babel/package.json#L13
I think the issue is related to babel perhaps:
babel/babel#10981
GiladShoham commentedon Apr 15, 2020
I'm not sure 3.8.3 is already in production, but we can publish it I think
l0gicgate commentedon Apr 15, 2020
@GiladShoham it would be great, Right now I'm at a standstill because of this and #89 / #2306
Tallyb commentedon Apr 16, 2020
davidfirst commentedon Apr 16, 2020
I just opened a PR for this. teambit/bit#2592
davidfirst commentedon Apr 17, 2020
Merged. Hopefully will be released early next week
qballer commentedon Apr 18, 2020
I've tested the prod branch on a trivial component with import type. It seems like there is a parsing
error (both production CLI and prod branch).
The component still builds thought, so in order to solve this issue it would be great if you can provide some link to example repo or a public bit component @l0gicgate.
l0gicgate commentedon Apr 18, 2020
@qballer provide a repo for what exactly? You reproduced the problem, what do you want me to do?
qballer commentedon Apr 18, 2020
There are two issues here from what I can tell. Bit's parsing has an error that involves the import type syntax and your component doesn't compile. The first might create issues with detecting dependencies but the compiler did manage to compile my component, so I'm wondering how exactly does it fail to compile on your end. A contrived example would do if there is an issue sharing source code.
l0gicgate commentedon Apr 18, 2020
@qballer the component compiles if I remove the
import typesynthax and simply useimport { MyType}