make HTTP timeouts configurable #27

Activity

1. myagley commented on Jun 25, 2014

   

   myagley

   on Jun 25, 2014

   Contributor

   More actions

   Hi Florian,

   We had wanted to allow setting of these parameters in the original design of the client but it looks like we haven't implemented it. Purely an oversight on our end. I apologize for that.

   I see two options:

   1. We expose methods to set the individual settings, like you suggested above
   2. We allow access to the underlying HttpClient which can be setup how you wish

   It looks like we have a public setter for the HttpClient, but the getter is private. I believe we could open up the getter. Then you would be able to mutate it and set it.

   Which option do you prefer?

   Mike
2. jack-kerouac commented on Jun 25, 2014

   

   jack-kerouac

   on Jun 25, 2014

   Author

   More actions

   I think hiding the HTTP client would be a better design approach. Right
   now, setting the individual timeouts is all I need. But this might change
   in the future...
   I am not sure.