worker deployment update-version-compute-config by jaypipes · Pull Request #1001 · temporalio/cli

jaypipes · 2026-04-27T18:27:13Z

Adds implementation of the UpdateWorkerDeploymentVersionComputeConfig gRPC API call with a temporal worker deployment update-version-compute-config CLI command. There is a --remove CLI flag that allows the user to explicitly delete the compute config from a Worker Deployment Version.

jaypipes · 2026-04-28T16:50:36Z

@chaptersix I don't believe the test failure has anything to do with this particular PR.

chaptersix · 2026-04-28T17:44:26Z

A couple things worth reconsidering here:

Command naming -- The CLI uses update-version-metadata for modifying properties on an existing version, and the gRPC API is UpdateWorkerDeploymentVersionComputeConfig. Using "replace" instead of "update" breaks the pattern -- we want CLI commands to be predictable so users can remember and guess at what a command or flag might be. Something like update-version-compute-config would be more consistent.

Implicit delete behavior -- Currently if --aws-lambda-function-arn is omitted, the command silently removes the compute config. That's surprising given no other command treats the absence of a flag as a destructive action. Something like a --remove flag (similar to how update-version-metadata uses --remove-entries) would make the behavior predictable and consistent with the rest of the CLI.

jaypipes · 2026-04-28T18:46:12Z

A couple things worth reconsidering here:

Command naming -- The CLI uses update-version-metadata for modifying properties on an existing version, and the gRPC API is UpdateWorkerDeploymentVersionComputeConfig. Using "replace" instead of "update" breaks the pattern -- we want CLI commands to be predictable so users can remember and guess at what a command or flag might be. Something like update-version-compute-config would be more consistent.

Implicit delete behavior -- Currently if --aws-lambda-function-arn is omitted, the command silently removes the compute config. That's surprising given no other command treats the absence of a flag as a destructive action. Something like a --remove flag (similar to how update-version-metadata uses --remove-entries) would make the behavior predictable and consistent with the rest of the CLI.

@chaptersix all great points. I will rework the patch!

jaypipes · 2026-05-13T17:03:47Z

@chaptersix sorry for the delay and thank you for your patience. I've updated the code per your review recommendations.

fretz12 · 2026-05-19T17:43:39Z

+		RequestId: requestID,
+	}
+
+	if c.Remove {


Though AwsLambdaFunctionArn, AwsLambdaAssumeRoleArn, AwsLambdaAssumeRoleExternalId are harmlessly ignored when --remove is passed in, there's precedence in this repo (i.e. see TemporalOperatorNexusEndpointCreateCommand) to guard against non-supported permutations. Maybe a guard like this in the top of the method:

if c.Remove && (c.AwsLambdaFunctionArn != "" || c.AwsLambdaAssumeRoleArn != "" || c.AwsLambdaAssumeRoleExternalId != "") { return fmt.Errorf("--remove cannot be combined with --aws-lambda-function-arn, --aws-lambda-assume-role-arn, or --aws-lambda-assume-role-external-id") }

fretz12 · 2026-05-19T18:03:57Z


+// awsLambdaProviderDetailsPayload returns the encoded Payload representing AWS
+// Lambda compute provider details.
+func (c *TemporalWorkerDeploymentUpdateVersionComputeConfigCommand) awsLambdaProviderDetailsPayload() (*commonpb.Payload, error) {


I think this looks functionally identical to TemporalWorkerDeploymentCreateVersionCommand.awsLambdaProviderDetailsPayload? Maybe refactor into a helper func

fretz12 · 2026-05-19T18:17:40Z

+	if c.AwsLambdaAssumeRoleExternalId != "" {
+		providerDetails["role_external_id"] = c.AwsLambdaAssumeRoleExternalId
+	}
+	err := validateAWSLambdaProviderDetails(providerDetails)


Seems this will reject if all three AWS Lambda flags are not supplied together. Maybe worth it to specify in help all 3 must be supplied together

The help strings for those three CLI options states that they are required when --aws-lambda-function-arn is specific

Adds implementation of the `UpdateWorkerDeploymentVersionComputeConfig` gRPC API call with a `temporal worker deployment replace-version-compute-config` CLI command. I used `replace` instead of `update` to be more explicit about the replacement semantics used by the command. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>

Changes the `temporal worker deployment replace-version-compute-config` CLI command to `temporal worker deployment update-version-compute-config` to match other CLI commands. Adds an explicit `--remove` CLI flag to remove the compute config on the version. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>

jaypipes · 2026-06-03T15:52:37Z

@fretz12 thanks very much for your code review and sorry for the long delay in pushing another revision. I've addressed your comments. thanks!

…#1104) ## Summary Backports server-independent changes from `main` into `release/1.8.x`. Every commit here was verified to build and pass codegen against the release line's current dependency pins (`server v1.31.0`, `sdk v1.41.1`, `api v1.62.8`) — nothing pulls in the newer server/SDK/API that landed on `main` via #1017. Scope agreed as: bug fixes + CLI changes + CI/tooling. Dependency bumps (#1040, #1052, #1063) and server-version-dependent features are intentionally excluded. ## Included (22 commits, cherry-picked with `-x`) **CLI / bug fixes** - #1006 Fix help with value flags (addresses #1003 — `--help` with value flags like `--address 123` surfaced `pflag: help requested` as an error) - #1012 skip CountWorkflow in batch operations when `--yes` is set - #1016 Sort output of listing search attributes - #1029 Workflow delete now prompts for confirmation - #1033 Add persistence info to start-dev banner - #1047 Add `temporal schedule list-matching-times` command - #1056 Fix task-queue config set help: use real fairness weight flag names - #1059 Prefix dev server cluster ID with `dev-server-` - #1089 fix: tls is not added for profiles without tls - #1099 Clarify activity pause timeout behavior - #941 auto-generate deprecation warnings from YAML config **Tests** - #1005 Fix flakey test by disabling EC2 metadata lookup - #1020 Remove `time.Sleep()` in commands.taskqueue_test.go **CI / tooling** - #1015 pin alpine docker image to 3.23.4 - #1024 remediate missing-dependency-cooldown - #1034 Bump actions/upload-artifact from 4 to 7 - #1044 improve dependabot config - #1045 add PR template - #1054 pin and bump GitHub Actions to latest versions - #1057 use allow instead of ignore for dependency-type in dependabot config - #1080 Bump the github-actions group with 2 updates ## Excluded (rely on the new server/SDK version) #1017 (server bump v1.31.0 -> v1.32.0-157.0), #1046, #1087, #1001, #1091, #1084 ## Verification - `go build ./...` passes - all test packages compile - `make gen` reports no codegen drift - server/sdk/api pins unchanged from `release/1.8.x` ## CI endpoint fix (added) Also backports the API-key CI test endpoint change from #1087 (`us-east-1` -> `ca-central-1`) as a standalone CI-only commit. This resolves the `Request unauthorized` failure in the "Test cloud API key" steps on `release/1.8.x`. The rest of #1087 (Nexus Operation command code) is excluded as it depends on the new server version. --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: Kevin Woo <3469532+kevinawoo@users.noreply.github.com> Co-authored-by: Rodrigo Zhou <rodrigo.zhou@temporal.io> Co-authored-by: Stephan Behnke <stephanos@users.noreply.github.com> Co-authored-by: Jiechen Zhong <jiechen.zhong@temporal.io> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Kent Gruber <kent.gruber@temporal.io> Co-authored-by: picatz <14850816+picatz@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: John Votta <jpvotta@gmail.com> Co-authored-by: Nasit Sarwar Sony <nasitsony96@gmail.com> Co-authored-by: hussam-salah <156124396+hussam-salah@users.noreply.github.com> Co-authored-by: Sai Asish Y <say.apm35@gmail.com> Co-authored-by: Bitalizer <23104115+bitalizer@users.noreply.github.com> Co-authored-by: Sean Kane <spkane31@gmail.com> Co-authored-by: Jessica Laughlin <JLDLaughlin@users.noreply.github.com>

jaypipes requested a review from a team as a code owner April 27, 2026 18:27

jaypipes force-pushed the jaypipes/replace-version-compute-config branch from afab676 to f6fdb9b Compare April 27, 2026 18:27

jaypipes changed the title ~~worker deployment replace-version-compute-config`~~ worker deployment replace-version-compute-config Apr 27, 2026

jaypipes requested a review from chaptersix April 27, 2026 20:28

chaptersix reviewed Apr 28, 2026

View reviewed changes

Comment thread internal/temporalcli/commands.yaml

jaypipes force-pushed the jaypipes/replace-version-compute-config branch 2 times, most recently from f6601f4 to bdd4c48 Compare April 28, 2026 16:40

jaypipes marked this pull request as draft April 28, 2026 18:46

jaypipes force-pushed the jaypipes/replace-version-compute-config branch from bdd4c48 to 6bedccf Compare May 13, 2026 17:03

jaypipes marked this pull request as ready for review May 13, 2026 17:03

jaypipes changed the title ~~worker deployment replace-version-compute-config~~ worker deployment update-version-compute-config May 13, 2026

fretz12 reviewed May 19, 2026

View reviewed changes

jaypipes force-pushed the jaypipes/replace-version-compute-config branch from 8fe9ef9 to 85f8a18 Compare June 3, 2026 15:51

jaypipes added 2 commits June 3, 2026 11:51

jaypipes force-pushed the jaypipes/replace-version-compute-config branch from 85f8a18 to 08a9b95 Compare June 3, 2026 15:52

Merge branch 'main' into jaypipes/replace-version-compute-config

76aef7d

fretz12 approved these changes Jun 9, 2026

View reviewed changes

chaptersix merged commit 700a87d into temporalio:main Jun 10, 2026
10 checks passed

chaptersix mentioned this pull request Jul 2, 2026

chore: backport server-independent changes from main to release/1.8.x #1104

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

worker deployment update-version-compute-config#1001

worker deployment update-version-compute-config#1001
chaptersix merged 3 commits into
temporalio:mainfrom
jaypipes:jaypipes/replace-version-compute-config

jaypipes commented Apr 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

jaypipes commented Apr 28, 2026

Uh oh!

chaptersix commented Apr 28, 2026

Uh oh!

jaypipes commented Apr 28, 2026

Uh oh!

jaypipes commented May 13, 2026

Uh oh!

fretz12 May 19, 2026

Uh oh!

jaypipes Jun 3, 2026

Uh oh!

fretz12 May 19, 2026

Uh oh!

jaypipes Jun 3, 2026

Uh oh!

fretz12 May 19, 2026

Uh oh!

jaypipes Jun 3, 2026

Uh oh!

jaypipes commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jaypipes commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jaypipes commented Apr 28, 2026

Uh oh!

chaptersix commented Apr 28, 2026

Uh oh!

jaypipes commented Apr 28, 2026

Uh oh!

jaypipes commented May 13, 2026

Uh oh!

fretz12 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

jaypipes Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

fretz12 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

jaypipes Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

fretz12 May 19, 2026

Choose a reason for hiding this comment

Uh oh!

jaypipes Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

jaypipes commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaypipes commented Apr 27, 2026 •

edited

Loading