Skip to content

Add missing "proto3-json-serializer" package to package.json - #289

Merged
mjameswh merged 2 commits into
mainfrom
add-proto3-json-serializer
Jun 21, 2023
Merged

Add missing "proto3-json-serializer" package to package.json#289
mjameswh merged 2 commits into
mainfrom
add-proto3-json-serializer

Conversation

@mjameswh

Copy link
Copy Markdown
Contributor

What was changed

  • Added missing "proto3-json-serializer" package to package.json.

Why

  • Add data_converter features in Typescript (#81) #286 added an import on that package, which would be transitively satisfied by imports on @temporalio/* when running features test in its own repo, but fails when running feature tests from the sdk-typescript repo.

@mjameswh
mjameswh requested a review from antlai-temporal June 21, 2023 21:55
@mjameswh
mjameswh merged commit eae330a into main Jun 21, 2023
@mjameswh
mjameswh deleted the add-proto3-json-serializer branch June 21, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants