fix flakey WorkflowUpdateTest.duplicateRejectedUpdate logic where ADMITTED was reported for updates that were actually COMPLETED.#2940
Merged
Conversation
…ITTED was reported for updates that were actually COMPLETED.
mjameswh
reviewed
Jul 3, 2026
| if (!accepted.isDone()) { | ||
| return UPDATE_WORKFLOW_EXECUTION_LIFECYCLE_STAGE_ADMITTED; | ||
| } else if (!outcome.isDone()) { | ||
| // A resolved outcome is terminal (a success result or a rejection/failure), so it always |
Contributor
There was a problem hiding this comment.
nit: comment formatting is weird
mjameswh
approved these changes
Jul 3, 2026
mjameswh
left a comment
mjameswh
left a comment
Contributor
There was a problem hiding this comment.
Please fix formatting issue before merging.
cconstable
force-pushed
the
workflow-update-test-flake
branch
from
48ef86d to
873ba8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
getStage()in the test server now checks the terminaloutcomefuture beforeaccepted, so an update's reported lifecycle stage no longer depends on the order those two futures complete. This fixes the flaky duplicateRejectedUpdate test, which could observe ADMITTED instead of COMPLETED for a rejected update.essentially, if it's done just say it's done and perform that logic check first.
Why?
WorkflowUpdateTest.duplicateRejectedUpdateintermittently failed, expecting stageCOMPLETEDbut observingADMITTED.