This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Repository navigation
Add Sequential{N} typealiases. - #934
Merged
Merged
Conversation
Add `Sequential{N}` generic typealiases.
These are easier to use than long nested `Sequential` types.
Member
Author
|
Generic typealiases with additional constraints aren't supported, so we can't land this anytime soon. I asked about potential support on the Swift forums. In the meantime, we'll have to deal with long nested var module: Sequential<Sequential<Conv2D<Float>, Sequential<Function<Tensor<Float>, Tensor<Float>>, Sequential<Conv2D<Float>, Sequential<BatchNorm<Float>, Sequential<Function<Tensor<Float>, Tensor<Float>>, Sequential<Conv2D<Float>, Sequential<BatchNorm<Float>, Function<Tensor<Float>, Tensor<Float>>>>>>>>>, Sequential<ConvLayer, Sequential<BatchNorm<Float>, Sequential<Function<Tensor<Float>, Tensor<Float>>, ConvLayer>>>>An alternative to long nested
|
The generic typealiases compile now!
Member
Author
|
Hey, generic typealiases can have Ready for review. |
dan-zheng
marked this pull request as ready for review
May 6, 2020 16:48
saeta
approved these changes
May 6, 2020
saeta
left a comment
Contributor
There was a problem hiding this comment.
This seems like a nice improvement. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Sequential{N}generic typealiases.These are easier to use than long nested
Sequentialtypes.