RationalFunction.__eq__: return NotImplemented for non-RationalFunction - #244
Closed
Chessing234 wants to merge 1 commit into
Closed
Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Avoid AttributeError when comparing to unrelated types; add a small regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RationalFunction.__eq__now returnsNotImplementedwhenotheris not aRationalFunction, matchingPolynomial.__eq__.Constraint.__eq__gets the same guard for non-Constraintoperands.test_rationalfunction_eq_regression.pyassertingR([1]) == 3isFalsewithout raisingAttributeError; wired intotest_all.py.Test plan
cd blueprint/src/python && python tests/test_rationalfunction_eq_regression.py(with project deps installed)python tests/test_all.pyclosing to replace this proposal with a clean commit history.