Repository navigation
Main section of Bower config does not work correctly with Wiredep #177
Description
Hi @terrymun ,
I use Wiredep for automatic injection of dependencies in many of my projects (technically I use grunt-wiredep). I'm using Fluidbox in one of my projects, and found that you have configured the main section of your bower.json file in a way that isn't compatible with Wiredep. (Wiredep did not pick up on Fluidbox's javascript files, and did not automatically inject them as dependencies.)
To fix this, I ended up overriding the bower.json main configuration for Fluidbox in my own bower.json file as follows:
"overrides": {
"fluidbox": {
"main": [
"dist/js/jquery.fluidbox.min.js",
"dist/css/fluidbox.min.css"
]
}
}
I believe the above is the current expected convention for bower.json main paths.
While this overrides solution is working for me, it would be nice if this could be fixed Fluidbox's bower.json config to adhere to convention and so that anyone else who uses Wiredep for dependency injection will not encounter the same problem.
If you're interested in fixing this issue, I'd be willing to submit a PR.
Many thanks,
Sarah
Activity
terrymun commentedon Oct 15, 2016
Hi @sarahquigley, sure, submit a PR if that's not too much trouble for you, that is very much appreciated. I have not worked with Wiredep before so I wouldn't know how to get bower.json configured properly for that purpose—but if this is going to help other people with integrating Fluidbox with Wiredep, why not? :)
sarahquigley commentedon Oct 15, 2016
Thanks so being so quick to respond @terrymun! It would be my pleasure to put together a PR - I'll do so this weekend. It'll be a small change. I have plenty of projects using Wiredep to check the fix on. :)
Thanks again! If only all project maintainers were so responsive!
terrymun commentedon Feb 22, 2017
Hi @sarahquigley, just checking on if you still intend to make a PR? If not, I will close this issue :)
sarahquigley commentedon Feb 22, 2017
Sorry! I totally forgot about this issue @terrymun. Let me fix it today. It's a really quick fix.