Add configurable site efficiency alert - #209
Merged
Merged
Conversation
shrutesh-tether
marked this pull request as ready for review
August 31, 2026 10:46
tekwani
reviewed
Aug 31, 2026
| dcsEnabled | ||
| ? fetchDcsThing(ctx, { id: 1, code: 1, type: 1, tags: 1, ...DCS_POWER_METER_FIELDS }) | ||
| : Promise.resolve(null), | ||
| dcsEnabled ? Promise.resolve(null) : getSiteConsumption(ctx) |
Contributor
There was a problem hiding this comment.
since it's the same flag may be use single condition -
dcsEnabled
? fetchDcsThing(ctx, { id: 1, code: 1, type: 1, tags: 1, ...DCS_POWER_METER_FIELDS })
: getSiteConsumption(ctx)
| for (const { key, severity } of SITE_EFFICIENCY_ALERT_TIERS) { | ||
| const conf = alertParams?.[key] | ||
| const threshold = conf?.maxSiteEfficiencyWThs | ||
| if (!conf?.enabled || typeof threshold !== 'number') continue |
Contributor
There was a problem hiding this comment.
check the config values first so computeSiteEfficiencyWPerTh doesn't get called every time.
mukama
previously approved these changes
Aug 31, 2026
tekwani
approved these changes
Aug 31, 2026
mukama
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Add configurable site efficiency alert