Add Icelake support in SOF#30
Conversation
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
I could take the first and last patches.
The second patch which deals with non-aligned things isn't clear to me. I just don't get why memcpy_to/fromio isn't sufficient or what the root cause of the problem is.
|
Yes, it is the first time I get this issue. I just know this type of limitation in PCI device yesterday |
The original function makes a mistake. It changes the value of dest data to zero but these data are out of write range Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
Icelake shares the setting of cannonlake because no difference between them in host Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
|
update my patch, only the first and last patches are reserved For second patch, I will fix the issue in another way. I will refine IPC data structure to make sure its size is 4 bytes aligned Thanks for review |
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
approved. Next time please make sure the commit subject is ASoC: SOF: intel: hda to make the merges/squashes easier.
2 participants
Add corresponding data structure and refine block read & write function to make it work on Icelake.
Test the patch on APL, CNL and ICL, pass