Skip to content

ASoC: SOF: topology: add abi checking#797

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
bardliao:tplg-abi
Apr 11, 2019
Merged

ASoC: SOF: topology: add abi checking#797
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
bardliao:tplg-abi

Conversation

@bardliao

@bardliao bardliao commented Apr 8, 2019

Copy link
Copy Markdown
Collaborator

Now we have abi information in topology manifest. therefore we can
add abi checking to avoid using a mismatched topology.

Signed-off-by: Bard liao yung-chuan.liao@linux.intel.com

@bardliao
bardliao requested review from plbossart and ranj063 April 8, 2019 06:44
@bardliao

bardliao commented Apr 8, 2019

Copy link
Copy Markdown
Collaborator Author

Should we add a magic number to make sure it is a abi number?

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of style issues and question on backwards compatibility with MINOR versions.

Comment thread sound/soc/sof/topology.c Outdated
Comment thread sound/soc/sof/topology.c Outdated
Comment thread sound/soc/sof/topology.c Outdated
Comment thread sound/soc/sof/topology.c Outdated
Comment thread sound/soc/sof/topology.c Outdated
@plbossart

Copy link
Copy Markdown
Member

@bardliao it'd like to submit this as part of v6 patches, please try and submit the update tomorrow morning. Otherwise I'll merge and add the dev_dbg myself. Thanks!

@bardliao

Copy link
Copy Markdown
Collaborator Author

@bardliao it'd like to submit this as part of v6 patches, please try and submit the update tomorrow morning. Otherwise I'll merge and add the dev_dbg myself. Thanks!

@plbossart done. Please feel free to edit it if you have a better sentence.

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if I missed something in earlier reviews, see question below and concern about the "we don't break userspace" rule.

Comment thread sound/soc/sof/topology.c Outdated
Now we have abi information in topology manifest, therefore we can
add abi checking to avoid using a mismatched topology.

Signed-off-by: Bard liao <yung-chuan.liao@linux.intel.com>
@plbossart

plbossart commented Apr 10, 2019 via email

Copy link
Copy Markdown
Member

@bardliao

Copy link
Copy Markdown
Collaborator Author

Thanks @plbossart @ranj063 the PR has updated.

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix checkpatch.pl issue, thanks. I don't like alignment that's out of whack.

@bardliao

Copy link
Copy Markdown
Collaborator Author

@plbossart done :)

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bardliao, this is a good check to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants