xtensa-build-zephyr.py: build rimage with -GNinja by default - #6732
Merged
Conversation
It's pointless and hardcodes the CMake generator. Also remove wrong comment added in commit 6cba64d ("xtensa-build-zephyr.py: fix a few minor pylint warnings") The rimage part of the comment was flat out wrong. The smex part of the comment is correct but in the wrong place. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This saves a couple seconds when building from scratch on Linux. On Linux the default CMake generator is "Makefiles" which is _not_ parallel by default. Thanks to the previous commit it's still possible to manually switch to "Makefiles" if desired. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
The Everything else is green. |
marc-hb
marked this pull request as ready for review
December 6, 2022 22:16
marc-hb
requested review from
fredoh9,
greg-intel,
keqiaozhang,
miRoox and
paulstelian97
December 6, 2022 22:17
lgirdwood
approved these changes
Dec 7, 2022
Member
|
@aborisovich good for Windows ? |
dbaluta
approved these changes
Dec 7, 2022
It looks like a temporary network issue, I clicked "Rerun failed job" and it got fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 commits
Very small change saves a couple seconds when building from scratch on Linux