Metadata API: add get_verification_result method#2481
Merged
Conversation
The method returns detailed information about signature verification of a delegated role metadata. Its implementation is taken from the verify_delegate method and slightly updated. verify_delegate now is a thin wrapper on top of get_verification_result. fixes theupdateframework#2449 Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu> Co-authored-by: Jussi Kukkonen <jkukkonen@google.com>
jku
approved these changes
Oct 3, 2023
jku
left a comment
jku
left a comment
Member
There was a problem hiding this comment.
Looks right to me but would maybe be useful to get review from someone else too, I wrote a bit too much of this to be able to see it with fresh eyes...
Contributor
|
I will have a look at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method returns detailed information about signature verification of a delegated role metadata.
Its implementation is taken from the verify_delegate method and slightly updated. verify_delegate now is a thin wrapper on top of get_verification_result.
fixes #2449