Skip to content

Carry main into redesign/main: the AI memory removal and Astra reply grounding (#746) - #788

Merged
thomasluizon merged 3 commits into
redesign/mainfrom
thomasluizon/ticket-746-carry-oct19e
Oct 19, 2026
Merged

thomasluizon merged 3 commits into
redesign/mainfrom
thomasluizon/ticket-746-carry-oct19e

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Summary

The standing main into redesign/main sync (thomasluizon/orbit-tickets#746). It carries two main commits with cherry-pick -x and changes no behaviour beyond carrying them:

  • 8e91cf66 Remove AI memory runtime surfaces (thomasluizon/orbit-tickets#235, orbit-api#783), as cfd0f768. Four conflicts, all line-level: the redesign-only Notion auto sync registrations and health window and the proactive Astra command stay; the AI memory lines leave (ServiceCollectionExtensions.BackgroundJobs.cs, BackgroundServiceHealthCheck.cs, CheckChatCommandQuery.cs, ExportUserDataQueryHandlerTests.cs).
  • f5446e1f Ground Astra replies in current-turn tool facts (thomasluizon/orbit-tickets#21, orbit-api#784), as 9ec41d4f. Its conflict in ProcessUserChatCommand.cs is semantic: redesign/main added ordered reply parts, the block answer path and the ask block. The merged pipeline keeps all three and grounds every reply that reaches the person: no cached FAQ answer for a block answer, a grounded cached FAQ answer otherwise, and when enforcement removes an ungrounded message the text parts leave with it while block parts and the ask block stay. ProcessUserChatCommandGroundingTests.Handle_PartsClient_GroundsTextAndPreservesOrderedBlocks failed on the unresolved behaviour and passes now.
  • f195e980 adapts the export assertion 8e91cf66 brought from main: redesign/main also exports proactiveItems, notionConnection and notionTasks.

Test evidence

  • dotnet build: exit 0.
  • dotnet test tests/Orbit.Domain.Tests, tests/Orbit.Application.Tests, tests/Orbit.Infrastructure.Tests: exit 0 each, on f195e980.
  • The generated OpenAPI files are unchanged by the build.

Manual steps

  • After merge, release the staging API from redesign/main (GitHub Actions, Release API, environment=staging, branch=redesign/main) and verify /health and the live commit.
  • Grounding enforcement stays off by default (log-only); no configuration is needed for this carry.

🤖 Generated with Claude Code

thomasluizon and others added 3 commits October 19, 2026 12:16
* Remove AI memory runtime surfaces (ORB-229)

* Preserve profile memory compatibility and finish removal cleanup (ORB-229)

(cherry picked from commit 8e91cf6)
* feat(chat): ground Astra text in current-turn tool results

* test(chat): cover grounding modes and current-turn provenance

* fix(chat): check localized numbers and exclude numeric identifiers

* test(chat): align habit prompt coverage with tool grounding

* fix(chat): ground schedule answers in canonical day facts

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit f5446e1)
…sertion

The AI memory removal (8e91cf6) asserts the full export property set as main
has it; redesign/main also exports proactiveItems, notionConnection and
notionTasks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes across the full carry from main into redesign/main, including the redesign-specific conflict resolutions.

  • Memory retirement: Reviewed removal of runtime endpoints, tools, extraction, prompts and scheduling while retaining schema mappings, cleanup paths and the required aiMemoryEnabled: false profile field; checked the merged client removal in orbit-ui-mobile#733.
  • Reply grounding: Reviewed current-turn fact extraction, localized token matching, warning-only defaults, optional enforcement, FAQ cache checks and streaming behavior. Grounding facts remain excluded from the HTTP response contract.
  • Redesign integration: Checked that enforced suppression removes ordered text parts without removing server-built blocks or the ask block, and that block-answer turns bypass FAQ caching. Notion scheduling and proactive Astra settings remain intact.
  • Schedule and export behavior: Reviewed canonical schedule-fact reuse for dated habit queries, done/remaining filtering, user-local dates, and preservation of the redesign-only export sections.
  • Verification: The complete Application and Infrastructure suites passed: 5,613 + 3,928 tests, with zero failures or skips. Generated OpenAPI files stayed unchanged and the worktree is clean. Live deployment, fleet-version gating and job-drain prerequisites were not independently verified.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@thomasluizon
thomasluizon merged commit be47b46 into redesign/main Oct 19, 2026
24 checks passed
@thomasluizon
thomasluizon deleted the thomasluizon/ticket-746-carry-oct19e branch October 19, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant