Repository navigation
Carry main into redesign/main: the AI memory removal and Astra reply grounding (#746) - #788
Merged
thomasluizon merged 3 commits intoOct 19, 2026
Merged
Conversation
* Remove AI memory runtime surfaces (ORB-229) * Preserve profile memory compatibility and finish removal cleanup (ORB-229) (cherry picked from commit 8e91cf6)
* feat(chat): ground Astra text in current-turn tool results * test(chat): cover grounding modes and current-turn provenance * fix(chat): check localized numbers and exclude numeric identifiers * test(chat): align habit prompt coverage with tool grounding * fix(chat): ground schedule answers in canonical day facts --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f5446e1)
…sertion The AI memory removal (8e91cf6) asserts the full export property set as main has it; redesign/main also exports proactiveItems, notionConnection and notionTasks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the full carry from main into redesign/main, including the redesign-specific conflict resolutions.
- Memory retirement: Reviewed removal of runtime endpoints, tools, extraction, prompts and scheduling while retaining schema mappings, cleanup paths and the required
aiMemoryEnabled: falseprofile field; checked the merged client removal inorbit-ui-mobile#733. - Reply grounding: Reviewed current-turn fact extraction, localized token matching, warning-only defaults, optional enforcement, FAQ cache checks and streaming behavior. Grounding facts remain excluded from the HTTP response contract.
- Redesign integration: Checked that enforced suppression removes ordered text parts without removing server-built blocks or the ask block, and that block-answer turns bypass FAQ caching. Notion scheduling and proactive Astra settings remain intact.
- Schedule and export behavior: Reviewed canonical schedule-fact reuse for dated habit queries, done/remaining filtering, user-local dates, and preservation of the redesign-only export sections.
- Verification: The complete Application and Infrastructure suites passed: 5,613 + 3,928 tests, with zero failures or skips. Generated OpenAPI files stayed unchanged and the worktree is clean. Live deployment, fleet-version gating and job-drain prerequisites were not independently verified.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
The standing
mainintoredesign/mainsync (thomasluizon/orbit-tickets#746). It carries twomaincommits withcherry-pick -xand changes no behaviour beyond carrying them:8e91cf66Remove AI memory runtime surfaces (thomasluizon/orbit-tickets#235,orbit-api#783), ascfd0f768. Four conflicts, all line-level: the redesign-only Notion auto sync registrations and health window and the proactive Astra command stay; the AI memory lines leave (ServiceCollectionExtensions.BackgroundJobs.cs,BackgroundServiceHealthCheck.cs,CheckChatCommandQuery.cs,ExportUserDataQueryHandlerTests.cs).f5446e1fGround Astra replies in current-turn tool facts (thomasluizon/orbit-tickets#21,orbit-api#784), as9ec41d4f. Its conflict inProcessUserChatCommand.csis semantic:redesign/mainadded ordered reply parts, the block answer path and the ask block. The merged pipeline keeps all three and grounds every reply that reaches the person: no cached FAQ answer for a block answer, a grounded cached FAQ answer otherwise, and when enforcement removes an ungrounded message the text parts leave with it while block parts and the ask block stay.ProcessUserChatCommandGroundingTests.Handle_PartsClient_GroundsTextAndPreservesOrderedBlocksfailed on the unresolved behaviour and passes now.f195e980adapts the export assertion8e91cf66brought frommain:redesign/mainalso exportsproactiveItems,notionConnectionandnotionTasks.Test evidence
dotnet build: exit 0.dotnet test tests/Orbit.Domain.Tests,tests/Orbit.Application.Tests,tests/Orbit.Infrastructure.Tests: exit 0 each, onf195e980.Manual steps
redesign/main(GitHub Actions, Release API,environment=staging,branch=redesign/main) and verify/healthand the live commit.🤖 Generated with Claude Code