Repository navigation
Carry main into redesign/main: the social removal and the grounding README (#746) - #790
Conversation
* Remove social runtime surfaces (ORB-233) * Finish social signup assertions and reference cleanup * ci: exclude the retained public profile shape from coverage The record is never built after the social removal; it stays only so the profile response schema keeps its shape for old clients until #685, and the committed OpenAPI snapshot holds that shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 7c79309)
Production data lives on Render Postgres; the Supabase project is deleted. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3330b8c)
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed both commits carrying the social runtime removal and grounding documentation correction into redesign/main, including the retained storage, credential compatibility, and consumer call sites.
- Social retirement: Removes social controllers, profile mutations, handlers, readers, policies, and agent catalog entries while retaining database mappings, export, and account-reset cleanup.
- Profile compatibility: Retains the profile response members with neutral social values and preserves redesign-specific fields; new accounts no longer receive social handles.
- Gamification: Removes friend-feed emission while preserving achievement notifications, XP, streak calculation, and freeze awards.
- Documentation and contracts: Updates the grounding database reference and regenerates both OpenAPI documents.
All 301 focused local tests passed across profile, provisioning, gamification, social retirement, existing credentials, OAuth, rate limits, and streaks. The full local suite was not rerun; GitHub Build, Unit Tests, OpenAPI Breaking-Change Gate, Guard Migrations, and Guard Conventions were green when checked. Some analysis and mutation checks remained in progress.
gpt-6.1-sol | 𝕏
|




Summary
The standing
mainintoredesign/mainsync (thomasluizon/orbit-tickets#746). It carries twomaincommits withcherry-pick -x:7c793090(orbit-api#787, thomasluizon/orbit-tickets#239): remove the social runtime surfaces. Tables and EF mappings stay for thomasluizon/orbit-tickets#1555; the profile keepshandlenull,socialOptInfalse andpublicProfilenull as compatibility fields until thomasluizon/orbit-tickets#685.3330b8cb(orbit-api#789): the grounding README names the Render database instead of the deleted Supabase project.Refs thomasluizon/orbit-tickets#746
Refs thomasluizon/orbit-tickets#239
Conflict resolution
src/Orbit.Api/Extensions/ServiceCollectionExtensions.cs: kept the redesign-onlyProactiveItem,NotionConnectionandNotionTaskrepository arguments beside the retained social repositories (the account reset still clears those tables); dropped the deletedSocialInteractionServicesandGamificationNotifiersregistrations, which nothing references after the removal.src/Orbit.Application/Profile/Queries/GetProfileQuery.csand its tests: applied#787's neutral compatibility fields and dropped the share URL dependency; every redesign-only profile field stays.src/Orbit.Api/openapi.jsonandopenapi_v2.json: regenerated bydotnet build, not hand merged; both still carryPublicProfileSettingsand thehandleandsocialOptInprofile properties.profile/handle,profile/social-opt-inandprofile/publicin its BFF (apps/web/app/api/[...path]/route.ts), so no redesign client calls a removed endpoint.Test evidence
dotnet build Orbit.slnxexit 0, withLANGunset and withLC_ALL=en_US.UTF-8.dotnet testper project, both settings, every exit 0:The carried
Handle_LegacySocialSettings_ReturnsNeutralCompatibilityFieldsfailed (exit 1) before the profile query resolution and passed after.HasPendingModelChanges()is false; no migration. The OpenAPI Breaking-Change gate runs in CI.Assumptions
None.
Manual steps
After merge, release the staging API from
redesign/main(GitHub Actions, Release API,environment=staging,branch=redesign/main) and verify/healthand the live commit. No new configuration, secrets or migrations.🤖 Generated with Claude Code