Skip to content

Carry main into redesign/main: the social removal and the grounding README (#746) - #790

Merged
thomasluizon merged 2 commits into
redesign/mainfrom
thomasluizon/ticket-746-carry-social-removal
Oct 19, 2026
Merged

thomasluizon merged 2 commits into
redesign/mainfrom
thomasluizon/ticket-746-carry-social-removal

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Summary

The standing main into redesign/main sync (thomasluizon/orbit-tickets#746). It carries two main commits with cherry-pick -x:

  • 7c793090 (orbit-api#787, thomasluizon/orbit-tickets#239): remove the social runtime surfaces. Tables and EF mappings stay for thomasluizon/orbit-tickets#1555; the profile keeps handle null, socialOptIn false and publicProfile null as compatibility fields until thomasluizon/orbit-tickets#685.
  • 3330b8cb (orbit-api#789): the grounding README names the Render database instead of the deleted Supabase project.

Refs thomasluizon/orbit-tickets#746
Refs thomasluizon/orbit-tickets#239

Conflict resolution

  • src/Orbit.Api/Extensions/ServiceCollectionExtensions.cs: kept the redesign-only ProactiveItem, NotionConnection and NotionTask repository arguments beside the retained social repositories (the account reset still clears those tables); dropped the deleted SocialInteractionServices and GamificationNotifiers registrations, which nothing references after the removal.
  • src/Orbit.Application/Profile/Queries/GetProfileQuery.cs and its tests: applied #787's neutral compatibility fields and dropped the share URL dependency; every redesign-only profile field stays.
  • src/Orbit.Api/openapi.json and openapi_v2.json: regenerated by dotnet build, not hand merged; both still carry PublicProfileSettings and the handle and socialOptIn profile properties.
  • The redesign web already refuses profile/handle, profile/social-opt-in and profile/public in its BFF (apps/web/app/api/[...path]/route.ts), so no redesign client calls a removed endpoint.

Test evidence

dotnet build Orbit.slnx exit 0, with LANG unset and with LC_ALL=en_US.UTF-8. dotnet test per project, both settings, every exit 0:

Project Passed per setting
Orbit.Domain.Tests 759
Orbit.Application.Tests 5,421
Orbit.Infrastructure.Tests 3,894
Orbit.Analyzers.Tests 32

The carried Handle_LegacySocialSettings_ReturnsNeutralCompatibilityFields failed (exit 1) before the profile query resolution and passed after. HasPendingModelChanges() is false; no migration. The OpenAPI Breaking-Change gate runs in CI.

Assumptions

None.

Manual steps

After merge, release the staging API from redesign/main (GitHub Actions, Release API, environment=staging, branch=redesign/main) and verify /health and the live commit. No new configuration, secrets or migrations.

🤖 Generated with Claude Code

thomasluizon and others added 2 commits October 19, 2026 13:47
* Remove social runtime surfaces (ORB-233)

* Finish social signup assertions and reference cleanup

* ci: exclude the retained public profile shape from coverage

The record is never built after the social removal; it stays only so the
profile response schema keeps its shape for old clients until #685, and the
committed OpenAPI snapshot holds that shape.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 7c79309)
Production data lives on Render Postgres; the Supabase project is deleted.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 3330b8c)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Reviewed both commits carrying the social runtime removal and grounding documentation correction into redesign/main, including the retained storage, credential compatibility, and consumer call sites.

  • Social retirement: Removes social controllers, profile mutations, handlers, readers, policies, and agent catalog entries while retaining database mappings, export, and account-reset cleanup.
  • Profile compatibility: Retains the profile response members with neutral social values and preserves redesign-specific fields; new accounts no longer receive social handles.
  • Gamification: Removes friend-feed emission while preserving achievement notifications, XP, streak calculation, and freeze awards.
  • Documentation and contracts: Updates the grounding database reference and regenerates both OpenAPI documents.

All 301 focused local tests passed across profile, provisioning, gamification, social retirement, existing credentials, OAuth, rate limits, and streaks. The full local suite was not rerun; GitHub Build, Unit Tests, OpenAPI Breaking-Change Gate, Guard Migrations, and Guard Conventions were green when checked. Some analysis and mutation checks remained in progress.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@sonarqubecloud

Copy link
Copy Markdown

@thomasluizon
thomasluizon merged commit bfe4cb7 into redesign/main Oct 19, 2026
24 checks passed
@thomasluizon
thomasluizon deleted the thomasluizon/ticket-746-carry-social-removal branch October 19, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant