[thomasluizon]

Summary

The standing main into redesign/main sync (thomasluizon/orbit-tickets#746). It carries two main commits with cherry-pick -x:

• 7a708b5b (orbit-api#792, thomasluizon/orbit-tickets#227 step 1 of 3): the persisted HabitSchedule, an immutable StartDate creation anchor beside the existing flags, an honest backfill, append-only schedule and startDate habit response fields, and the compatibility trigger. The migration 20261019165331_ExpandHabitScheduleAndStartDate applies on the staging database at the next staging API release.
• 05ab55f0 (orbit-api#791, thomasluizon/orbit-tickets#230): the handwritten pragma and SuppressMessage lines are removed and every finding they hid is fixed at its cause; the generated log helpers become extension methods.

Refs thomasluizon/orbit-tickets#746
Refs thomasluizon/orbit-tickets#227
Refs thomasluizon/orbit-tickets#230

Conflict resolution

• src/Orbit.Api/openapi.json and openapi_v2.json: regenerated by dotnet build, not hand merged. Both carry schedule, startDate and the string HabitSchedule enum; FrequencyUnit is unchanged, so the onboarding request contract does not narrow.
• tests/Orbit.Infrastructure.Tests/Persistence/FeatureFlagAccountsMigrationTests.cs: keeps the redesign branch's checks, reads the renewal columns from Users only, and asserts the observed difference count.
• The migration's .Designer.cs target model and OrbitDbContextModelSnapshot.cs were regenerated for the redesign model (the redesign-only entities and AddAstraBlockAnswerReplay stay in it). The migration's Up, Down and trigger SQL are byte-identical to #792. A new test, TargetModel_PreservesRedesignAndMatchesCurrentModel, failed against the auto-merged main Designer and passes against the regenerated one; a ProbeNoChanges migration generated through OrbitDbContextFactory had an empty Up and Down and was deleted.
• AgentCatalogService.*: #791's constructor and logging pattern applied with every redesign-only capability, surface and catalog entry (proactive, Notion) kept.
• src/Orbit.Infrastructure/Services/ProactiveCheckinSchedulerService.cs stays deleted on this branch, so #791's edit to it and its allowlist entry are omitted.

Test evidence

dotnet build Orbit.slnx exit 0, with LANG unset and with LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8. dotnet test per project, both settings, every exit 0:

Project	Passed per setting
Orbit.Domain.Tests	797
Orbit.Application.Tests	5,441
Orbit.Infrastructure.Tests	3,935
Orbit.Analyzers.Tests	40

The suppression guard tests pass 40 of 40. The OpenAPI Breaking-Change Gate runs in CI. A strict local rebuild with -p:TreatWarningsAsErrors=true reports the existing CS0618 (Message.Token deprecated in FirebaseAdmin) in PushNotificationService and its tests, which neither commit touches and the repository build does not treat as an error; main has the same code.

Assumptions

None.

Manual steps

After merge, release the staging API from redesign/main (GitHub Actions, Release API, environment=staging, branch=redesign/main), then verify /health, the live commit and the 20261019165331_ExpandHabitScheduleAndStartDate row in __EFMigrationsHistory. No new configuration or secrets.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pullfrog]

✅ No new issues found.

Reviewed changes Reviewed both carried commits against redesign/main, including persistence, client compatibility, and redesign-specific conflict resolutions.

• Habit expansion: Adds persisted HabitSchedule and immutable StartDate alongside the existing fields, without switching scheduling readers or changing create/update requests.
• Migration and rollout: Adds the guarded backfill, sync timestamp refresh, and legacy-writer compatibility trigger; preserves the redesign model in the regenerated migration Designer and snapshot.
• Response compatibility: Appends optional fields to habit and sync responses and documents them in both OpenAPI versions; checked the sibling repository's shared schemas and preserved legacy fields.
• Suppression cleanup: Reviews logging guards and extensions, OAuth query binding, MediatR cancellation forwarding, timestamp analyzer changes, and catalog simplification, including retained proactive and Notion entries.

Validation: 408 focused checks passed across domain, application, infrastructure, analyzer, and suppression-guard tests. GitHub Build, Unit Tests, and OpenAPI Breaking-Change Gate also passed. PostgreSQL trigger execution and live staging-data preflight were not repeated locally; source PR #792 documents PostgreSQL proof and the zero-invalid-row deployment prerequisite.

  ^{｜ View workflow run ｜ Using gpt-6.1-sol ｜ 𝕏}