Repository navigation
Fix/habit time input formatting - #45
Merged
Merged
Conversation
Introduce keyboard-aware scroll utilities and components and apply them across mobile screens and bottom sheets to improve keyboard UX (new KeyboardAwareScrollView/BottomSheet variants and hook). Update AppTextInput to integrate input reveal behavior. Harden habit form inputs with BufferedSheetInput enhancements (draft syncing, transform/onDraftChange, focus handling) and add unit tests for habit form time formatting. Add/adjust goal support: action-chips now include goal action types and labels, chat invalidates goal queries and opens GoalDetailDrawer on goal chips, and GoalDetailDrawer fixes state reset and progress form population. Misc: BottomSheetModal uses safe-area insets and adjusted keyboard behavior, several modals/screens (profile, login, support, onboarding, create/edit goal, create/edit/log habit) switched to keyboard-aware scroll views, and tests/mocks updated accordingly.
Add stable IDs for editable habits and switch list keys to use them to avoid rekeying issues. Implement a draft/value sync in BottomSheetAppTextInput (isFocused, draftValue, lastSyncedValue) to prevent parent-driven value updates from clobbering the user's in-progress edits and wire up onBlur/onChangeText accordingly. Overhaul keyboard-aware scrolling: track keyboard frame and scroll offset, measure input positions via UIManager.measureInWindow, compute target scroll Y, and support scrollTo/scrollToOffset or responder fallbacks. Also forward onScroll from ScrollView/FlatList/BottomSheetScrollView into the keyboard-aware context so focused inputs are reliably scrolled into view. These changes fix focus/value glitches and make input reveal/scroll behavior more robust across scrollable types.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.