Repository navigation
Fix all-view one-time child visibility - #70
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07b0e74e1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (habit.isGeneral) return false | ||
| if (showCompleted) return true | ||
| return !habit.isCompleted || habit.frequencyUnit !== null |
There was a problem hiding this comment.
This predicate now removes every completed one-time child from the All view when showCompleted is off, but it does not account for descendant visibility. If a completed one-time child still has active/recurring descendants, getVisibleChildren drops that node and the UI traversal only walks returned children, so the entire subtree becomes unreachable in All view. This is a regression from the prior behavior where non-general children remained visible and their descendants could still be shown.
Useful? React with 👍 / 👎.
Summary
Tests