Repository navigation
Add generic Step chains with current execution and reporting support - #386
Conversation
|
this is still waiting for review? |
ee84889 to
eabdbd1
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
eabdbd1 to
2042654
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Rebased onto current main and completed the generic-chain implementation in 2042654; this PR is now ready for review and closes #266. All 12 test projects, the .NET 10.0.402 Release solution build, documentation build, and 28 compiled documentation examples passed. Core: 2,256 passed, 2 skipped for Windows symbolic-link privileges. The optional generalized StepKeyword/phase/strict-order proposal is not adopted in this PR: #266's current acceptance criteria call for compatible generic chains. Keeping the existing builder families and historical enum values delivers that scope without a report-model migration. Generic steps share the current execution, text generation, cancellation and reporting paths. |
[Medium impact] The PR appears safe to merge; the previous example failure is fixed and no new actionable issues remain. SummaryAdds generic
No new actionable issues were found in the changes since the previous review. Reviews (2) · Last reviewed commit: "Fix generic step report keywords and det..." · Reviewed by Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2042654140
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed both reviews in f591177 and resolved all three threads. The HTTP example findings are fixed with deterministic responses and matching OK assertions. The report keyword finding is fixed in both splitters, with regression assertions for standalone and hosted markup and matching documentation. Validation: .NET SDK 10.0.402 Release solution build passed with zero warnings/errors; all 12 test projects passed (xUnit and TUnit projects run through their Microsoft.Testing.Platform entry points). Core: 2,256 passed, two skips for Windows symbolic-link privileges. All five comparison examples and five focused generic-step tests passed. Documentation production build passed. The rendering regression failed before the fix. Fresh CI/review is pending; no merge attempted in this unit. |
Generic
Step(...).Step(...)chains now use the current scenario definition/execution pipeline and can execute a single step or any number of steps without Given/When/Then phases.StepType.Step, records the new public APIs for both core targets, and enables source-generator/analyzer recognition.The optional StepKeyword/custom-phase/strict-order proposal in #266 is not adopted here. The current issue body requires compatible generic chains; replacing the existing builder families and report model is a separate architectural change. This implementation meets those acceptance criteria without changing existing Given/When/Then APIs or historical enum values.
Validation: .NET SDK 10.0.402 Release solution build (0 warnings/errors); all 12 test projects pass, including core 2,256 passed and 2 skipped because this Windows host lacks symbolic-link privileges; five focused generic-step regressions pass. Documentation production build and compiled-sample checks pass. NUnit's intentional framework-outcome tests retain their expected skips.
Closes #266