chore(deps): update dependency nunit to v5 - #6903
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe NUnit package version changes to 5.0.0. Analyzer detection, test assembly references, generated migration snippets, and migration documentation are updated for NUnit 5. ChangesNUnit 5 migration support
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The NUnit 5 update preserves the repository’s inspected benchmark and analyzer-test workflows, and the generated migration snippets use NUnit 5 namespaces. No concrete user-facing or build/test regression remains, so the change is ready to merge after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the NUnit trail, Comment |
|
72a1bdc to
096d8a0
Compare
096d8a0 to
1070562
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1070562db2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
NUnit 5 still ships ClassicAssert in NUnit.Framework.Legacy (nunit.framework.legacy.dll), but moved StringAssert, CollectionAssert, FileAssert and DirectoryAssert back to the NUnit.Framework namespace, and Assert.ThrowsAsync now returns an awaitable Task. - Doc snippet generator: alias StringAssert/CollectionAssert to NUnit.Framework. - NUnit migration guide: await ThrowsAsync in the NUnit example (CS4014 under NUnit 5). - NUnit migration analyzer: also detect NUnit.Framework.StringAssert when probing whether NUnit is referenced. - Analyzer tests: reference NUnit's net8.0 build. NUnit 5's net10.0 build references System.Runtime 10.0 and raises CS1705 against the verifier's Net90 reference assemblies.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Updated [TUnit](https://github.com/thomhurst/TUnit) from 1.70.1 to 1.71.0. <details> <summary>Release notes</summary> _Sourced from [TUnit's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.71.0 <!-- Release notes generated using configuration in .github/release.yml at v1.71.0 --> ## What's Changed ### Other Changes * perf: lighter per-test trace bookkeeping for the HTML report (-12% allocations at 10k tests) by @thomhurst in thomhurst/TUnit#6910 * perf(html-report): parallel report serialization + optimized hot writers (-26% end-of-session time) by @thomhurst in thomhurst/TUnit#6911 * perf: emit source-generated test types after user code (Defender scan 5s → 0.2s at 10k tests) by @thomhurst in thomhurst/TUnit#6908 * perf(source-gen): bound generated test-entry methods (data-driven startup JIT -45%) by @thomhurst in thomhurst/TUnit#6909 * fix: avoid blocking waiting callers during IAsyncInitializer initialization by @Sing303 in thomhurst/TUnit#6906 * perf(analyzers): cut binding and symbol lookups in analyzer hot paths (TUnit.Analyzers -89% on TestProject) by @thomhurst in thomhurst/TUnit#6917 * fix(source-gen): model equality covers every emitted field; infrastructure refreshes on reference changes by @thomhurst in thomhurst/TUnit#6912 * perf(mocks): memoize generator discovery per compilation and decouple emitted source from call-site locations by @thomhurst in thomhurst/TUnit#6913 * fix(packaging): skip the source generator when disabled and replace the broken Polyfill injection by @thomhurst in thomhurst/TUnit#6915 * refactor(analyzers): address review feedback from #6917 by @thomhurst in thomhurst/TUnit#6919 * perf(source-gen): remove whole-compilation scans from static property, property injection and AOT converter generators by @thomhurst in thomhurst/TUnit#6914 * perf(assertions-source-gen): make assertion generators properly incremental by @thomhurst in thomhurst/TUnit#6916 * perf(source-gen): make TestMetadataGenerator pipeline values equatable by @thomhurst in thomhurst/TUnit#6918 ### Dependencies * chore(deps): update dependency polyfill to 11.4.1 by @thomhurst in thomhurst/TUnit#6900 * chore(deps): update dependency polyfill to 11.4.1 by @thomhurst in thomhurst/TUnit#6899 * chore(deps): update dependency tunit.aspire to 1.7* by @thomhurst in thomhurst/TUnit#6901 * chore(deps): update tunit to 1.7* by @thomhurst in thomhurst/TUnit#6902 * chore(deps): update dependency coverlet.collector to 10.1.0 by @thomhurst in thomhurst/TUnit#6905 * chore(deps): update dependency nunit to v5 by @thomhurst in thomhurst/TUnit#6903 **Full Changelog**: thomhurst/TUnit@v1.70.1...v1.71.0 Commits viewable in [compare view](thomhurst/TUnit@v1.70.1...v1.71.0). </details> Updated [TUnit.AspNetCore](https://github.com/thomhurst/TUnit) from 1.70.1 to 1.71.0. <details> <summary>Release notes</summary> _Sourced from [TUnit.AspNetCore's releases](https://github.com/thomhurst/TUnit/releases)._ ## 1.71.0 <!-- Release notes generated using configuration in .github/release.yml at v1.71.0 --> ## What's Changed ### Other Changes * perf: lighter per-test trace bookkeeping for the HTML report (-12% allocations at 10k tests) by @thomhurst in thomhurst/TUnit#6910 * perf(html-report): parallel report serialization + optimized hot writers (-26% end-of-session time) by @thomhurst in thomhurst/TUnit#6911 * perf: emit source-generated test types after user code (Defender scan 5s → 0.2s at 10k tests) by @thomhurst in thomhurst/TUnit#6908 * perf(source-gen): bound generated test-entry methods (data-driven startup JIT -45%) by @thomhurst in thomhurst/TUnit#6909 * fix: avoid blocking waiting callers during IAsyncInitializer initialization by @Sing303 in thomhurst/TUnit#6906 * perf(analyzers): cut binding and symbol lookups in analyzer hot paths (TUnit.Analyzers -89% on TestProject) by @thomhurst in thomhurst/TUnit#6917 * fix(source-gen): model equality covers every emitted field; infrastructure refreshes on reference changes by @thomhurst in thomhurst/TUnit#6912 * perf(mocks): memoize generator discovery per compilation and decouple emitted source from call-site locations by @thomhurst in thomhurst/TUnit#6913 * fix(packaging): skip the source generator when disabled and replace the broken Polyfill injection by @thomhurst in thomhurst/TUnit#6915 * refactor(analyzers): address review feedback from #6917 by @thomhurst in thomhurst/TUnit#6919 * perf(source-gen): remove whole-compilation scans from static property, property injection and AOT converter generators by @thomhurst in thomhurst/TUnit#6914 * perf(assertions-source-gen): make assertion generators properly incremental by @thomhurst in thomhurst/TUnit#6916 * perf(source-gen): make TestMetadataGenerator pipeline values equatable by @thomhurst in thomhurst/TUnit#6918 ### Dependencies * chore(deps): update dependency polyfill to 11.4.1 by @thomhurst in thomhurst/TUnit#6900 * chore(deps): update dependency polyfill to 11.4.1 by @thomhurst in thomhurst/TUnit#6899 * chore(deps): update dependency tunit.aspire to 1.7* by @thomhurst in thomhurst/TUnit#6901 * chore(deps): update tunit to 1.7* by @thomhurst in thomhurst/TUnit#6902 * chore(deps): update dependency coverlet.collector to 10.1.0 by @thomhurst in thomhurst/TUnit#6905 * chore(deps): update dependency nunit to v5 by @thomhurst in thomhurst/TUnit#6903 **Full Changelog**: thomhurst/TUnit@v1.70.1...v1.71.0 Commits viewable in [compare view](thomhurst/TUnit@v1.70.1...v1.71.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR contains the following updates:
4.6.1→5.0.0Release Notes
nunit/nunit (NUnit)
v5.0.0: Version 5.0.0See release notes for details.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.
Summary by CodeRabbit