Repository navigation
chore(deps): update dependency imposter to 0.2.19 - #7034
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This PR only updates the centrally managed Imposter version to 0.2.19. No concrete merge-blocking behavior is evident, so it is ready to merge subject to normal checks. Pre-merge checks |
|
|
5b01039 to
ce997a4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce997a4215
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PackageVersion Include="Microsoft.Testing.Platform" Version="2.5.1" /> | ||
| <PackageVersion Include="Microsoft.Testing.Platform.MSBuild" Version="2.5.1" /> | ||
| <PackageVersion Include="Imposter" Version="0.2.17"/> | ||
| <PackageVersion Include="Imposter" Version="0.2.19"/> |
There was a problem hiding this comment.
Align the pinned Imposter version with the reviewed update
The commit title, dependency table, and release notes describe an update from 0.2.17 to 0.2.18, but this line actually selects 0.2.19. Version 0.2.19 is a separate upstream release with additional generator changes, so the benchmark project would consume code that was not represented in the dependency review; pin 0.2.18 or update the commit metadata and release notes to review 0.2.19 explicitly.
Useful? React with 👍 / 👎.
This PR contains the following updates:
0.2.17→0.2.19Release Notes
themidnightgospel/Imposter (Imposter)
v0.2.19: Cross-kind name clashes, re-abstracted ref members, method type parameter namesCompare Source
Fixes
Currentproperty and aCurrent()method, got an imposter that failed with CS0102. These members now take apart names on the imposter, like same-kind members already did. The target's own member names are unchanged.Get<GetDelegate>,Get<IGetMethodImposterBuilder>andGet<GetMethodImposterCollection>(CS0694, CS1503), andGet<Builder>orGet<Adapter>(CS0102). The method's generated types and nested classes now take other names in that case.v0.2.18: Events whose type doesn't bindCompare Source
Fixes
System.Actionshadowed by a type namedSystem), or an event declared with a non-delegate type, made the generator report IMP005 and drop that target's imposter. With a Debug build of the generator, every imposter of the project was dropped. Such an event is now left out of the imposter, the compiler's own error stays the one to fix, and the rest of the imposter is generated.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate CLI.