[BUG] Trailing slash in docker-compose.yml will break login direct

[SamScripting]

Describe the Bug

- TINYAUTH_APPURL=https://tinyauth.domain.com

In the docker-compose, if you add a trailing slash to this url, Tinyauth will pass this to the web browser and cause a broken login link by not trimming it while passing.

IE, instead of https://tinyauth.domain.com/login..., you'll get https://tinyauth.domain.com//login...`, which causes a 404 to be returned.

I'm not savviest person with docker in general, but I somewhat assume this is not intrinsic to docker itself as opposed to Tinyauth's handling of the string.

How to Reproduce

Add a trailing slash to the TINYAUTH_APPURL variable in the docker-compose.

Expected Behavior

For trailing slashes to be trimmed when passed.

Additional Context

No response

Logs

No response

Operating System

Fedora 43

Browser

Firefox (tried chrome too)

Tinyauth Version

v5.0.0

Docker Version (if applicable)

29.5.3

Human Written Confirmation

• I confirm this issue was written by me and not generated by an LLM or AI assistant.

[steveiliop56]

@SamScripting thank you for the report. This was caused by an incorrect dependency in the proxy controller:

tinyauth/internal/bootstrap/router_bootstrap.go

Lines 94 to 96 in 479f165

	proxyController := controller.NewProxyController(controller.ProxyControllerConfig{
	AppURL: app.config.AppURL,
	}, apiRouter, app.services.accessControlService, app.services.authService)

Which used the raw app URL (config.AppURL) from the config instead of the parsed one (app.context.appUrl). This code has been completely refactored to both fix this issue and to not allow such mistakes to happen in the future due to the removal of the manual config wiring.

In simpler words, this issue will be fixed in the next version of Tinyauth ; )