You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove the orphaned webviewNotifications frontend module #5481
Follow-up split out of #5478 (PR 1), where it was deliberately left alone rather than bundled into a deletion stack.
What
app/src/lib/webviewNotifications/ (4 files: index.ts, service.ts, types.ts, service.test.ts) is orphaned on main.
Zero importers.grep -rn "webviewNotifications" app/src returns only hits inside the directory itself.
Its producer is gone. The module's whole job is listen<WebviewNotificationFired>(WEBVIEW_NOTIFICATION_FIRED_EVENT, …) (service.ts:39). That event was emitted by the Tauri webview_accounts module, deleted in PR 1 of Remove the CDP layer and every surface that depends on it #5478. Nothing emits it now.
Deleting it is not self-contained. service.ts imports focusAccountFromNotification and noteWebviewNotificationFired from store/accountsSlice, and accountsSlice / types/accounts.ts still serve the live channel-accounts surface — six real consumers including OpenhumanLinkModal.tsx, AddAccountModal.tsx, providerIcons.tsx and the slice itself. Those are tinychannels-backed connections and have nothing to do with the removed CDP webview surface.
So this needs someone to decide, per symbol, whether the accountsSlice actions and any WEBVIEW_NOTIFICATION_* state they touch are dead alongside the module or still reachable from the channel-accounts path. That is a frontend judgement call on a live surface, not the mechanical dead-code removal the #5478 stack is doing.
Suggested scope
Delete app/src/lib/webviewNotifications/.
Audit accountsSlice for reducers/actions left with no caller (focusAccountFromNotification, noteWebviewNotificationFired, and any webviewNotification* state fields), and remove only those with zero remaining consumers.
Leave types/accounts.ts and the channel-accounts surface intact. The stale comment at types/accounts.ts:23 (which mentions webview_account_reveal) can be dropped in passing.
app/src/lib/webviewNotifications/ is absent from main, deleted by 78f411631"refactor: remove dead frontend code". The deletion was the whole of the ask here.
Thanks for spotting it; orphaned modules are easy to walk past. Please reopen if any part of it survived elsewhere.
Activity
tinysweeper commentedon Aug 10, 2026
task
Labelled
priority: p3.M3gA-Mind commentedon Sep 1, 2026
Closing as done — the module was removed.
app/src/lib/webviewNotifications/is absent frommain, deleted by78f411631"refactor: remove dead frontend code". The deletion was the whole of the ask here.Thanks for spotting it; orphaned modules are easy to walk past. Please reopen if any part of it survived elsewhere.