[oxoxDev]

Summary

• Embedded Google Meet now matches stock Chrome for cam, mic, screenshare, captions, in-call chat, reactions, raise-hand, session persistence, and hangup-return UX.
• Per-origin Browser.grantPermissions for meet.google.com adds audioCapture / videoCapture / displayCapture / clipboardReadWrite so getUserMedia succeeds without Meet's "Use microphone and camera" consent dialog.
• Two routing leaks closed: (a) post-account-pick workspace.google.com marketing redirect → rewritten to meet.google.com/; (b) "Start now" / room-popup → kept in-app via parent navigation instead of leaking to system Chrome.
• 6 new unit tests (origin_host_is accept/reject + 4 popup-routing cases). Manual smoke logged in docs/qa/GMEET-PARITY.md (15-row matrix, 11 ✅).
• Two follow-ups filed before opening this PR: Ingest Google Meet caption transcripts via memory_doc_ingest #1052 (caption transcript ingestion feature) and Google Meet background effects fail in CEF ("something went wrong") #1053 (background effects CEF runtime gap).

Problem

Surfaced during the #1022 parity audit smoke against pnpm dev:app:

1. Cam/mic gap — Gmeet's pre-call greenroom showed its own "Use microphone and camera" consent dialog and clicking it was a no-op. Root cause: Browser.grantPermissions for the gmeet CDP session granted only notifications (added by fix(webview/slack): scanner spawn + notifications + post-pushState target match (#1016) #1028 for Slack), so getUserMedia returned NotAllowedError and Gmeet's web client fell back to its own consent UI which the embedded view couldn't satisfy.
2. Workspace marketing leak — after the user picked an account in the in-app sign-in flow, Google's edge SSR-redirected to workspace.google.com/products/meet/.... provider_allowed_hosts("google-meet") lists a bare google.com suffix (webview_accounts/mod.rs:108-113); url_is_internal matches workspace.google.com against .google.com so the navigation committed and the user landed on the Workspace marketing page instead of Meet.
3. "Start now" leak — clicking "Start an instant meeting" / "New meeting" calls window.open(meet.google.com/<roomid>). The default on_new_window chain had no in-app handler for gmeet's own host (popup_should_navigate_parent only matched the Google auth popup; popup_should_stay_in_app is slack/zoom-only), so the URL fell through to open_in_system_browser and the meeting opened in Chrome — the user lost the in-app session entirely.

A fourth gap surfaced during smoke (auth post-2FA refresh, audit row 1) but is fixed by PR #1046's is_google_sso_host predicate. This PR documents the dependency in docs/qa/GMEET-PARITY.md and stays out of that surface.

Solution

Per-origin Meet permission grant — cdp/session.rs

Extends Browser.grantPermissions to dispatch a per-provider permission set. Default for every embedded provider is ["notifications"]. For meet.google.com (matched via the new origin_host_is(origin, host) helper) it additionally grants audioCapture, videoCapture, displayCapture, clipboardReadWrite. Origin-scoped so Slack / WhatsApp / Telegram / Discord / Browserscan grants are unaffected.

Workspace marketing rewrite — webview_accounts/mod.rs::on_navigation

Pre-intercept inside the existing on_navigation closure. For the google-meet provider, if the navigation host is workspace.google.com (or any subdomain), the original navigation is cancelled and the embedded parent is navigated to https://meet.google.com/. Logged for diagnostics.

Room-popup parent navigation — popup_should_navigate_parent

Extends the existing gmeet branch (which already handled the Google auth popup) to also match meet.google.com hosts. The popup is denied and the embedded parent is navigated into the room URL, so "Start now" / room-link clicks stay in the same in-app tab the user clicked from.

Audit dossier — docs/qa/GMEET-PARITY.md

Mirrors the GMAIL-PARITY.md shape: 15-row acceptance matrix pre-filled from the smoke run, hardcoded constants table, smoke procedure, CDP-migration sketch, sign-off block.

Submission Checklist

• Tests added or updated — 2 unit tests for origin_host_is (accept/reject) + 4 unit tests for popup_should_navigate_parent (gmeet room popup, gmeet landing popup, workspace not navigating parent, unrelated link not navigating parent).
• N/A: this PR delivers a webview-parity audit row already tracked in docs/qa/GMEET-PARITY.md, not a new TEST-COVERAGE-MATRIX feature row, so no matrix sync applies.
• All affected feature IDs from the matrix are listed in the PR description under ## Related.
• No new external network dependencies introduced — same Meet origin as the existing webview; mock backend untouched.
• N/A: parity work for an already-shipping webview surface — covered by the [Feature] webview: Google Meet — full end-to-end parity with native app #1022 audit dossier (docs/qa/GMEET-PARITY.md); no new release-cut surface added.
• Linked issue closed via Closes #NNN in the ## Related section.

Impact

• Desktop only — CEF runtime + Tauri shell. No frontend / web / CLI changes.
• Permission grants — origin-scoped to https://meet.google.com. No other provider's permission set changes. Permissions are limited to the four Meet actually exercises during a call (audio capture, video capture, display capture for screenshare, clipboard for copy-meeting-link).
• Routing changes — gmeet-specific. The workspace rewrite only fires for workspace.google.com (and subdomains) when the active provider is google-meet. The room-popup parent-nav only fires for meet.google.com hosts when the active provider is google-meet.
• Performance — no new background tasks. One additional Browser.grantPermissions argument list at session attach.
• Security — no new origins, no new JS injection, no new credential surfaces. Permission grants are origin-scoped via CDP and tied to the per-account CEF profile.
• Migration — none.

Related

• Closes [Feature] webview: Google Meet — full end-to-end parity with native app #1022
• Fixes Fix Google Meet webview landing page and post-2FA auth refresh #1035
• Builds on fix(webview/slack): scanner spawn + notifications + post-pushState target match (#1016) #1028 (Slack notifications grant — same Browser.grantPermissions infra reused)
• Depends on feat(gmail): native OS notifications via Atom-feed poll (#1020) #1046 for audit row 1 (Auth) — once feat(gmail): native OS notifications via Atom-feed poll (#1020) #1046 merges and this branch rebases on main, the is_google_sso_host predicate keeps the post-password SetSID hop in-app and CEF lands cookies natively. No additional change needed in this PR.
• Follow-up TODOs:
  • Ingest Google Meet caption transcripts via memory_doc_ingest #1052 — [Feature] Gmeet caption transcript ingestion via memory_doc_ingest (replaces current log-only handler at webview_accounts/mod.rs:2219-2247)
  • Google Meet background effects fail in CEF ("something went wrong") #1053 — [Bug] Gmeet background effects fail in CEF — "something went wrong" (Chromium runtime gates absent in CEF for MediaPipe segmentation pipeline)
  • CDP migration of recipe.js scraping (separate epic; sketched in GMEET-PARITY.md CDP-migration section)

Summary by CodeRabbit

• New Features

  • Google Meet popups and navigation now remain within the app instead than opening externally.
  • Automatic permission grants for audio capture, video capture, and screen sharing on Google Meet.

• Bug Fixes

  • Improved handling of Google Meet landing page redirects within the webview.

• Documentation

  • Added Google Meet webview compatibility testing matrix.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes implement Google Meet-specific webview optimizations: dynamic CDP permission grants for meet.google.com (notifications, audio/video capture, display capture, clipboard), popup navigation interception to retain Meet sessions in-webview, and workspace.google.com redirect detection with automatic redirection to canonical meet.google.com. A comprehensive QA parity checklist is added.

Changes

Cohort / File(s)	Summary
CDP Permission Grants app/src-tauri/src/cdp/session.rs	Builds permission list dynamically for Browser.grantPermissions: always grants notifications, and additionally grants audioCapture, videoCapture, displayCapture, clipboardReadWrite when origin host matches meet.google.com. Adds case-insensitive origin_host_is helper with port-tolerance and includes unit tests.
Meet Popup & Redirect Handling app/src-tauri/src/webview_accounts/mod.rs	Intercepts Google Meet popups to prevent external-browser routing; popup_should_navigate_parent returns Some(url) for google-meet popups targeting meet.google.com. Detects workspace.google.com redirects during navigation commits and asynchronously cancels/replaces them with redirect to https://meet.google.com/. Includes new navigation-decision tests.
QA Parity Documentation docs/qa/GMEET-PARITY.md	Introduces comprehensive Google Meet webview parity audit matrix covering auth, landing, meeting creation/join, media, screenshare, captions, chat, reactions, lifecycle, and hangup flows. Documents observed behaviors, links to existing child issues (#1046, #1052, #1053), enumerates code-level gaps, includes constants reference, and sketches CDP-based caption extraction migration path.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A rabbit hops through Meet with glee,
Permissions granted, cam and mic are free,
No pesky popups, no workspace waylay,
Just Google Meet, where we video all day! 📹✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR partially addresses linked issues: it implements permission grants for media features and fixes routing leaks for #1022 and #1035, but does not implement transcript ingestion or caption extraction that are core acceptance criteria.	Implement memory_doc_ingest for caption transcript persistence and harden caption extraction logic to fully satisfy #1022 acceptance criteria beyond permission grants.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: granting native camera/microphone/screenshare permissions and keeping Google Meet routing in-app.
Out of Scope Changes check	✅ Passed	All changes are scoped to Google Meet webview parity: permission grants, routing fixes, tests, and documentation align with #1022 and #1035 objectives without introducing unrelated modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src-tauri/src/webview_accounts/mod.rs`:
- Around line 1466-1469: The log call in the webview-accounts module currently
logs the full `url` (see the log::info! that reports "gmeet workspace marketing
redirect intercepted"), which may include sensitive query/fragment data; to fix,
parse or sanitize `url` before logging (e.g., create `redacted_url` by using
url::Url::parse(&url) and clearing query/fragment or by taking the part before
'?' and '#'), then replace `url` in the log::info! call with `redacted_url` so
only the safe path/host is recorded.

In `@docs/qa/GMEET-PARITY.md`:
- Line 75: The result tally in the GMEET-PARITY sign-off line double-counts the
same blocked item `#1046`; update the summary string in docs/qa/GMEET-PARITY.md
(the "Result: 11 ✅ / 0 ⚠️ / 2 ❌ ..." line) to remove the duplicate "1 ❌ blocked
on `#1046`" entry so the counts add up consistently (e.g., consolidate to a single
"2 ❌ (one blocked on `#1046`, one deferred to `#1053`)" or adjust counts so the
totals match the listed breakdown).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb45b5fa-12f2-40ed-b1ac-24a407577dbe

📥 Commits

Reviewing files that changed from the base of the PR and between a225bd9 and 0dbaaa7.

📒 Files selected for processing (3)

• app/src-tauri/src/cdp/session.rs
• app/src-tauri/src/webview_accounts/mod.rs
• docs/qa/GMEET-PARITY.md

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Redact redirected URL before logging

Line 1467 logs the full URL. This path can carry query/fragment data, so logging raw values risks persisting sensitive auth/navigation artifacts. Log a redacted version instead.

Suggested patch

-                    log::info!(
-                        "[webview-accounts] gmeet workspace marketing redirect intercepted ({}); rewriting parent to https://meet.google.com/",
-                        url
-                    );
+                    log::info!(
+                        "[webview-accounts] gmeet workspace marketing redirect intercepted ({}); rewriting parent to https://meet.google.com/",
+                        redact_navigation_url(url)
+                    );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src-tauri/src/webview_accounts/mod.rs` around lines 1466 - 1469, The log
call in the webview-accounts module currently logs the full `url` (see the
log::info! that reports "gmeet workspace marketing redirect intercepted"), which
may include sensitive query/fragment data; to fix, parse or sanitize `url`
before logging (e.g., create `redacted_url` by using url::Url::parse(&url) and
clearing query/fragment or by taking the part before '?' and '#'), then replace
`url` in the log::info! call with `redacted_url` so only the safe path/host is
recorded.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix inconsistent verdict tally in sign-off

Line 75 appears to double-count the #1046 blocked item (2 ❌ ... plus another 1 ❌ blocked on #1046``). Please normalize to a single consistent breakdown so totals are unambiguous.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docs/qa/GMEET-PARITY.md` at line 75, The result tally in the GMEET-PARITY
sign-off line double-counts the same blocked item `#1046`; update the summary
string in docs/qa/GMEET-PARITY.md (the "Result: 11 ✅ / 0 ⚠️ / 2 ❌ ..." line) to
remove the duplicate "1 ❌ blocked on `#1046`" entry so the counts add up
consistently (e.g., consolidate to a single "2 ❌ (one blocked on `#1046`, one
deferred to `#1053`)" or adjust counts so the totals match the listed breakdown).