Repository navigation
[codex] Use tinychannels provider implementations - #4557
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (14)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 277fdbcaff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| channels.push(Arc::new(SlackChannel::with_http_client( | ||
| sl.bot_token.clone(), | ||
| sl.channel_id.clone(), | ||
| sl.allowed_users.clone(), | ||
| crate::openhuman::config::build_runtime_proxy_client("channel.slack"), |
There was a problem hiding this comment.
When proxy_config updates or disables proxy settings it calls set_runtime_proxy_config, which clears the runtime client cache so callers of build_runtime_proxy_client pick up the new proxy on the next request. Before this change Slack/Signal/WhatsApp built their client lazily inside each send/poll/health call; this startup path now passes a prebuilt reqwest::Client into the tinychannels provider, which stores and clones that same client, so a running channel keeps sending/polling through the old proxy configuration until the core is restarted. Keep a lazy client factory here or rebuild/restart these channels when the runtime proxy config changes.
Useful? React with 👍 / 👎.
…ls_* The "catalog canonical methods exist in core schema registry" test read src/openhuman/channels/controllers/schemas.rs for the channels_* namespace/ function literals, but tinyhumansai#4557 ("Use tinychannels provider implementations") moved the actual ChannelControllerSchema definitions (namespace: "channels", ...) into the vendored vendor/tinychannels/src/controllers/schemas.rs crate — the in-tree file now only adapts from it. This left the drift guard failing on main independent of this PR (verified: same failure reproduces against main's own copy of both files); fixed by also reading the vendored schema source. Claude-Session: https://claude.ai/code/session_01QpsTTxxjFgDhzuozS28tyU
Summary
Dependency
Validation