Repository navigation
chore(vendor): bump tinyhumans-sdk to the typed medulla namespace - #5260
Conversation
Picks up tinyhumansai/sdk#4, which replaces DynamicResponse with typed models across the medulla and orchestration namespaces and adds an SSE session event stream. Nothing here changes. This host uses TinyHumansClient, Error, LoginTokenRequest, and the jwt helpers, none of which that release touches; it does not call the medulla or orchestration namespaces at all. The bump is what lets medulla-public consume the typed API, and it is the prerequisite for retiring this repo's own copy of the Medulla client under src/openhuman/medulla/client/. Validation: cargo check --no-default-features --features medulla.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
senamakel has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d24a40f626
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit ca47efe93d5fc9978cc8e19da2582ae2bc96284b | |||
| Subproject commit 5fc82c5c0a1fe30b31155aeeeb2d9efe3caf4af9 | |||
There was a problem hiding this comment.
This SDK revision adds the SSE implementation and its direct async/stream dependencies, but the tinyhumans-sdk entries in both Cargo.lock and app/src-tauri/Cargo.lock still contain the old dependency list (only base64, percent-encoding, reqwest, serde, serde_json, thiserror, and url). Consequently, any root or desktop build using --locked fails because Cargo needs to update the lockfile; this also breaks the repository's cargo tree --locked checks. Regenerate and commit both lockfiles after updating the submodule.
Useful? React with 👍 / 👎.
The vendored sdk bump (tinyhumansai#5260) added futures + tokio to tinyhumans-sdk's dependency set without regenerating either Cargo.lock, so every --locked cargo invocation (Rust Quality lane's TLS-policy check, coverage lanes) fails with 'cannot update the lock file'. Also picks up the tinyflows reqwest rename normalization from the same merge. No version changes.
…sai#5260) `vendor/tinyhumans-sdk` gained `futures` and `tokio` dependencies, but the submodule bump in tinyhumansai#5260 landed without regenerating either `Cargo.lock`. The Rust Quality lane runs `scripts/check-linux-tls-dependencies.sh`, whose `cargo tree --locked` then refuses to proceed: error: cannot update the lock file ... because --locked was passed Main's own CI Lite run skipped the Rust lanes (tinyhumansai#5260 touched no Rust source), so this only surfaces on Rust-touching PRs, which build the merge with main. Adds the two missing dependency entries to both Cargo worlds. No version changes.
Summary
Bumps
vendor/tinyhumans-sdkfromca47efeto5fc82c5, picking up tinyhumansai/sdk#4, which:DynamicResponsewith typed models across themedullaandorchestrationnamespacessrc/sse.rs— an SSE session event stream with reconnect and seq dedupeUpdateTaskRequest.recurrence, where clearing a rule was silently dropped)Impact on this repo: none
This host uses
TinyHumansClient,Error,LoginTokenRequest, and thejwthelpers. None of those change in that release, and this host does not call themedulla()ororchestration()namespaces at all — so nothing here needs to change alongside the bump.Why bump it now
It is the prerequisite for
medulla-publicconsuming the typed API, since that repo vendors the SDK through this one.It is also the first step toward retiring this repo's own copy of the Medulla client at
src/openhuman/medulla/client/. That copy is a near-identical fork of the one inmedulla-public— their SSE modules differ by 4 lines,client/program/types.rsby 26 — and both can now collapse onto the shared SDK. That cleanup is deliberately not in this PR.Validation
cargo check --no-default-features --features medulla— clean.