Skip to content

test(sandbox-panel): wait for the loaded panel, not for the load to start #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 1 commit into from
Sep 12, 2026
Merged

test(sandbox-panel): wait for the loaded panel, not for the load to start #6064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/src/components/settings/panels/__tests__/SandboxSettingsPanel.validation.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,16 @@ const mockIsTauri = vi.mocked(isTauri);
async function renderLoaded(overrides: Partial<SandboxSettings> = {}) {
mockGet.mockResolvedValue({ result: sandboxSettings(overrides), logs: [] });
renderWithProviders(<SandboxSettingsPanel />);
await waitFor(() => expect(mockGet).toHaveBeenCalled());
// Not `waitFor(() => expect(mockGet).toHaveBeenCalled())`: the panel calls
// openhumanGetSandboxSettings synchronously inside its mount effect, so that
// assertion already holds on waitFor's first tick, while isLoading is still
// true and the panel is rendering the loading paragraph. The synchronous
// getBy* accessors below then query a DOM that has no fields in it yet. The
// same trap is described under flushPersist; it applies to readiness too.
//
// The backend select is rendered only by the loaded branch and by every
// override these tests pass, so awaiting it is the signal that was meant.
await screen.findByRole('combobox', { name: /backend/i });
}

/**
Expand Down
Loading