Repository navigation
fix(ci): fail the MCP write audit at the module seam in the diagnostics test - #7761
Conversation
…cs test Since 605ca6e the MCP write audit lives in the TinyMCP module, which picks its storage provider once per process at load. A file as the workspace no longer reaches it, so diagnostics reported recent_rows Some(0) instead of the expected None. The test now disables modules on the broken config, so the module client is unavailable and the diagnostics report the audit as failed (recent_rows None, non-empty last_error). That is the surface this test owns. Storage failures inside the audit are tinymcp's to cover (storage/failing.rs).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 15 minutes for your next included review. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
Directly linked open issue #7759 requires four other raw_coverage_all fixes: host storage for the two Composio tests, approval failure injection at the opened database, and the curated round20 tool-… |
Implement the four coding objectives from #7759 in this PR, with their required test changes and unchanged failure assertions where specified. Alternatively, remove the direct link if this PR is intentionally limited to the excluded diagnos… |
| Out of Scope Changes check | |
The PR changes tool_registry_diagnostics_reports_config_and_audit_store_failures. Issue #7759 explicitly lists this test as not included and assigns it to a separate failure-injection change. The ch… |
Move the diagnostics test fix to a separate PR with the appropriate issue link, or update the linked issue scope and acceptance criteria before including this change. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the test-only change: making the MCP write audit fail at the module seam in the diagnostics test. It is specific and matches the pull request objective. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Full details: Linked Issues check
-
Explanation
Directly linked open issue
#7759requires four otherraw_coverage_allfixes: host storage for the two Composio tests, approval failure injection at the opened database, and the curated round20 tool-list expectation. The reviewed diff changes onlytool_registry_diagnostics_reports_config_and_audit_store_failures, which#7759explicitly excludes. The required four fixes are therefore not implemented by this PR.Resolution
Implement the four coding objectives from
#7759in this PR, with their required test changes and unchanged failure assertions where specified. Alternatively, remove the direct link if this PR is intentionally limited to the excluded diagnostics test.
Full details: Out of Scope Changes check
-
Explanation
The PR changes
tool_registry_diagnostics_reports_config_and_audit_store_failures. Issue#7759explicitly lists this test as not included and assigns it to a separate failure-injection change. The change is therefore outside the scope of the directly linked issue, even though it is a test-only fix.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the test setup with care,
Modules rest, while diagnostics run there.
The workspace path waits by the door,
The audit provider is reached no more.
One small fixture change completes the chore.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The test disables modules to fail the write audit at the module seam;
check last_error names that seam ("MCP module unavailable", from
mcp/audit/mod.rs) instead of only being non-empty.
Tiny Sweeper reviewTiny Sweeper completed its review; deterministic results follow. State: Ready for maintainer review Review snapshot
Completeness: Complete Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0019 · 134,915 in / 26,777 out · 36,992 cached (27%) · ladder/vectors-oai3, deepseek-v4.1-flash · 93 embedded
critique: $0.0010 · 55,712 in / 14,155 out · 17,536 cached (31%) · deepseek-v4.1-flash
security: $0.0003 · 51,629 in / 4,100 out · 14,336 cached (28%) · deepseek-v4.1-flash
description: $0.0004 · 25,615 in / 5,542 out · 5,120 cached (20%) · deepseek-v4.1-flash
tinysweeper
Bot
added
the
priority: p3
2 participants
Summary
openhuman-cli::raw_coverage_all tool_registry_approval_raw_coverage_e2e::tool_registry_diagnostics_reports_config_and_audit_store_failuresin CI Fast on main (run 38441930612; same failure on main5a5c68ab00in run 38447185171).Problem
Since 605ca6e the write audit lives in the TinyMCP module (
mcp::audit::list_writes→McpConfiguredClient). In tinymcp v0.18.0 the module picks its storage provider once per process, at load: host storage if it can connect, otherwise an in-memory default (tinybus_module/mod.rssetup). A file used asworkspace_dirtherefore no longer breaks the audit.list_writessucceeds with zero rows, and the diagnostics reportSome(0).Solution
modules.enabled = false.McpConfiguredClient::for_configreturnsUnavailable,list_writeserrors, and the existing assertions hold as written:recent_rows == Noneand a non-emptylast_error.crates/tinymcp/src/storage/failing.rs).raw_coverage_all.Submission Checklist
Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
N/A
Validation Run
rustfmt --checkon the changed file.Summary by CodeRabbit