Repository navigation
refactor(agent): pin tinyagents main and migrate host to TurnStates - #7763
Merged
Merged
Conversation
Update the pinned commits for the vendored submodules to their latest revisions. Auto-committed-on: dragonfly
Update the vendored tinyconnectors, tinydocs, tinyflows, tinyhosts, tinyhumans-sdk, tinyjuice, tinymcp, tinysearch, tinyvoice, and tinywallet submodules to their latest commits. Auto-committed-on: dragonfly
Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the vendored tinyflows submodule to the latest upstream commit. Auto-committed-on: dragonfly
Update the vendored tinyflows submodule to a newer revision. Auto-committed-on: dragonfly
Auto-committed-on: dragonfly
Thread deletion now removes the associated session store entries so workspace and turn state data do not linger after a thread is gone. Previously these records were left behind, leaking storage and occasionally resurfacing stale state for reused thread ids. Auto-committed-on: dragonfly
Dropped the unused tinyagents_session::turn_state imports from the thread crud and purge operations, clearing the resulting compiler warnings with no behaviour change. Auto-committed-on: dragonfly
Dropped several unused imports from the runtime bootstrap, streaming ops, profile recovery, thread edit, and web chat modules to keep the code warning-free. Auto-committed-on: dragonfly
Use the fully qualified std::sync::Arc for the turn_state_store parameter instead of relying on an imported Arc, avoiding ambiguity with other Arc types in scope. Auto-committed-on: dragonfly
Sessions are now written to and read from the workspace directory so conversation state survives restarts. The store resolves paths relative to the workspace root instead of relying on in-memory state alone. Auto-committed-on: dragonfly
Adds handling for multimodal content in agent messages so images and other non-text parts can be carried alongside text through the agent pipeline. Auto-committed-on: dragonfly
Attachments are now carried through the agent harness graph and session driver so multimodal inputs reach the model alongside text. Subagent dispatch was updated to forward the same attachment context. Auto-committed-on: dragonfly
ResolvedChat now accepts the shared Arc directly, so the SharedChatModel wrapper that boxed it is no longer needed. This removes the adapter and its imports, passing the chat model through unchanged. Auto-committed-on: dragonfly
…ut of order The mirror now reconciles incoming turn-state observations against the latest known revision instead of overwriting unconditionally, so stale updates no longer clobber newer state. Tests cover the reordering cases that previously produced inconsistent mirrored turns. Auto-committed-on: dragonfly
Adds coverage for host profile handling, session import, turn state editing, and op conversion. These tests exercise the new behaviour introduced by the recent refactor. Auto-committed-on: dragonfly
Turn state now carries multimodal attachments through to the agent so images and other files sent from the web chat reach the model instead of being dropped. Added tests covering the attachment handling path and documented the flow in the web chat README. Auto-committed-on: dragonfly
Auto-committed-on: dragonfly
Auto-committed-on: dragonfly
The lockfile still pinned tinystoragedrivers-core and tinystoragedrivers-secrets at 0.7.0 alongside their 0.8.0 counterparts, so every dependent had to disambiguate between the two versions. Removing the leftover 0.7.0 packages collapses each dependency onto a single version, and the vendored tinyagents submodule is bumped to match. Auto-committed-on: dragonfly
Attachment placeholders now resolve from the blob stash first and only fall back to legacy sidecar files for ids the stash lacks, so conversations written before the stash still render while stashed bytes win when both exist. The legacy index lookup was also made testable by taking the directory as a parameter. Auto-committed-on: dragonfly
Record anyhow as a dependency of tinyagents-runtime in the lockfile so the resolved dependency graph matches the crate's manifest. Auto-committed-on: dragonfly
Combine the two separate tinyagents_session use statements into a single grouped import in the progress bridge. No behaviour change. Auto-committed-on: dragonfly
The end-to-end test now seeds turn snapshots through the session store's turn_states_for handle instead of the old turn_state store function, matching the current persistence API. Auto-committed-on: dragonfly
Update the vendored tinyagents submodule to the latest commit. Auto-committed-on: dragonfly
[pin-rewind] OpenHuman main pinned tinyagents 047cda3e, a side branch (tsd-0.8.0-on-oh-pin-7655) that was never merged. tinyagents main (6d8a9196) already carries the tinystoragedrivers v0.8.0 bump (#433) and adds #430/#434/#436 and #437 (tinyinference on tsd v0.8.0), so the old pin is deliberately dropped. Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7 tasks
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 2
📒 Files selected for processing: 31
Comment |
36 tasks done
Tiny Sweeper reviewTiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Incomplete Review snapshot
Completeness: Incomplete FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Could not review: crates/openhuman-core/src/agent/session_host/driver.rs, crates/openhuman-core/src/profiles/recovery.rs, crates/openhuman-core/src/threads/ops/purge.rs, crates/openhuman-core/src/web_chat/progress_bridge.rs, crates/openhuman-core/src/web_chat/progress_bridge_tests.rs, crates/openhuman-core/src/web_chat/run_task.rs Before merge
How this fits togetherflowchart LR
n0["rehydrate_image_placeholders<br/>changed"]:::changed
n1["row_has_image_placeholders<br/>changed"]:::changed
n2["stash_image_attachments<br/>changed"]:::changed
n3["...lder_rehydrates_to_disk_path_for_provider<br/>changed"]:::changed
n4["...achments_replaces_marker_with_placeholder<br/>changed"]:::changed
n0 -->|calls| n1
n3 -->|calls| n0
n3 -->|tests| n0
n3 -->|calls| n2
n3 -->|tests| n2
n4 -->|calls| n2
n4 -->|tests| n2
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
There was a problem hiding this comment.
tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/openhuman-core/src/agent/session_host/driver.rs, crates/openhuman-core/src/profiles/recovery.rs, crates/openhuman-core/src/threads/ops/purge.rs, crates/openhuman-core/src/web_chat/progress_bridge.rs, crates/openhuman-core/src/web_chat/progress_bridge_tests.rs, crates/openhuman-core/src/web_chat/run_task.rs.
$0.0081 · 1,903,544 in / 110,537 out · 391,808 cached (21%) · ladder/vectors-oai3, deepseek-v4.1-flash, · 778 embedded
critique: $0.0070 · 1,120,899 in / 97,069 out · 248,192 cached (22%) · deepseek-v4.1-flash,
security: $0.0006 · 609,727 in / 6,448 out · 85,248 cached (14%) · deepseek-v4.1-flash
tests: $0.0001 · 102,004 in / 1,367 out · 34,560 cached (34%) · deepseek-v4.1-flash
description: $0.0001 · 48,525 in / 582 out · 23,808 cached (49%) · deepseek-v4.1-flash
tinysweeper
Bot
added
the
priority: p3
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7540, #7523
Refs #7688, #7522, #7727
Closes #7632
What
vendor/tinyagentsto tinyagents main6d8a9196(contains feat(refer) : Implement referral system with UI components and API integration #430, [Prompt] Agent prompt improvement #434, Fix: telegram replies #436, the tinystoragedrivers v0.8.0 bump #433, and tinyagents#437 below). Keeps tinystoragedrivers at v0.8.0 and the root[patch]tables pointing at the tinyagents copy.6d8a9196): main already had tsd 0.8.0 (#433), so the planned merge oftsd-0.8.0-on-oh-pin-7655was a no-op. The remaining gap was main's vendored tinyinference, which still named tsd by git tag v0.7.0 and split theSecretStore/DocumentStoretypes. feat(subconscious): stabilize heartbeat + subconscious loop (#392) #437 bumps tinyinference to its main (tsd v0.8.0) and patches the git deps onto the vendored path so--lockedpasses on Windows.turn_state::store/TurnStateStore/AttachmentStashto theTurnStatesport andBlobAttachmentStash:agent::session_storegainsturn_states_for(calling tenant),default_turn_states_for(boot/recovery sweeps) andattachment_stash_for. All resolve through the installed provider, else the workspace default backend, so a session store / storage-URL install supplies the port and a classic workspace gets aDriverSessionStoresover its sqlite backend.run_task,progress_bridge), flows streaming, threads ops (turn_state_*, delete, purge, edit truncation), profiles recovery and core runtime bootstrap take the port. The truncation helper resolves the store beforespawn_blockingbecause the tenant is task-local.stash_image_attachmentswrites to the blob stash (no cap, no expiry, as before).rehydrate_image_placeholdersis now async: it returns the stashed bytes as an inlinedata:URI and falls back to legacy<id>.<ext>sidecars in<workspace>/attachmentsfor conversations written before the move.SharedChatModelwrapper ininference/http/backend.rs(ResolvedChatholds anArcnow).Behaviour kept
A resumed thread's turn state and its attachments survive a restart: they are in the storage backend, not process memory. Legacy
turn_states/files are still imported by the storage domain (storage::import::sessions); the cold-boot sweep marks leftover non-terminal snapshots interrupted.Tests added or changed
agent::session_store:a_threads_turn_state_survives_a_restart_of_the_workspace_store,a_stashed_attachment_survives_a_restart_of_the_workspace_store(drop every cached handle/backend, then read back; sweep persists).agent::multimodal: stash -> rehydrate -> provider round trip now asserts an inline data URI;legacy_sidecar_files_stay_indexed_by_id.Verification
cargo check --manifest-path Cargo.toml(default),-p openhuman-cli --features "$(scripts/ci/product-features.sh)",-p openhuman --no-default-features,--workspace --tests: passcargo check --manifest-path crates/openhuman-app/Cargo.toml,cargo build -p openhuman-cli --bin openhuman-core: passcargo test -p openhuman --lib(RUST_MIN_STACK=16777216) for web_chat (253), flows (574), profiles (191), core::runtime (138), inference (431), agent::session_store (17), agent::multimodal (19), agent::attachments (55), storage::import (27): passjson_rpc_e2e(--features voice,web3): 102 passed, 5 ignored;openhuman-rpcsession_store: passnode scripts/ci/check-submodule-monotonic.mjs upstream/main: OK with[pin-rewind]declared (the old pin047cda3ewas a never-merged side branch; main supersedes it); onlyvendor/tinyagentsdiffers from upstream/mainpnpm rust:layout: onlycore/observability.rs3479 lines (limit 3477), identical on upstream/maincheck-saas-ambient.mjs(5 bare-spawn sites inmodules/storage_import_*,sandbox/shell_exec.rs) andcheck-agent-runtime-boundary.mjs(3 re-exports in files this PR does not touch): fail identically on upstream/mainFailing tests (pre-existing, not from this change)
threads::store::bus::tests::*(8):channels/module_fixture_tests.rspanics "tinychannels-module fixture unavailable: blocked on tinybus 0.1.4".#7727 stays open: its other leaves (embeddings, http_error/models/context_window, factory,
agent/tinyagents/model.rs) are untouched here.