Skip to content

ci(storage): run the MongoDB driver suite nightly, not on every PR - #8084

Merged
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:ci-mongodb-nightly-only
Oct 18, 2026
Merged

senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:ci-mongodb-nightly-only

Conversation

@senamakel

@senamakel senamakel commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Storage (MongoDB) no longer runs on pull requests. It keeps running nightly on main and on demand (workflow_dispatch).
  • Updated the matching comments in .github/ci-paths-filter.yml and docs/ci-self-hosted.md.

Problem

  • It took 10–13 hosted-runner minutes per PR push. Any change under vendor/**, Cargo.lock or about 30 core domain paths triggered it.
  • It is not a required check, so it never gated a merge. The last 9 PR runs all failed.
  • The shipped desktop product compiles only storage-sqlite (scripts/ci/product-features.txt). MongoDB backs the SaaS profiles, and this workflow compiles a feature set no other lane builds.

Solution

  • Removed the pull_request trigger. The nightly schedule still catches a driver regression within a day, and workflow_dispatch covers a PR that deliberately changes a driver.
  • Memory, sqlite and file driver coverage is unchanged: it stays in the storage-drivers lane of CI Fast.

Submission Checklist

  • Tests added or updated: N/A, workflow trigger only. self-hosted-lanes.test.mjs (including the MongoDB target-parity test) still passes, 39/39.
  • Diff coverage ≥ 80%: N/A, no code.
  • Coverage matrix updated: N/A.
  • Affected feature IDs: N/A.
  • No new external network dependencies.
  • Manual smoke checklist: N/A.
  • Linked issue: N/A, part of the EX63/CI speed-up work following ci: measure the merged EX63 workflow and warm repeat #8070.

Impact

  • CI only: fewer hosted minutes and less noise on storage-touching PRs. A MongoDB-only regression now surfaces in the nightly run instead of on the PR.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: ci-mongodb-nightly-only
  • Commit SHA: see branch head

Validation Run

  • pnpm --filter openhuman-app format:check: N/A
  • pnpm typecheck: N/A
  • Focused tests: node --test scripts/__tests__/self-hosted-lanes.test.mjs (39 passed), actionlint .github/workflows/storage-mongodb.yml
  • Rust fmt/check: N/A
  • Tauri fmt/check: N/A

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

  • Intended behavior change: MongoDB storage e2e runs nightly and on demand, not per PR.
  • User-visible effect: none.

Parity Contract

  • Legacy behavior preserved: same jobs, targets and replica-set setup; only the trigger changed.
  • Guard/fallback/dispatch parity checks: the target-parity test still covers the workflow's --test list.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none
  • Canonical PR: this
  • Resolution: N/A

Summary by CodeRabbit

  • Chores
    • MongoDB storage checks now run nightly on main or on demand, rather than automatically for pull requests.
    • Updated CI documentation to clarify when and where these checks run.

The MongoDB storage lane no longer runs on pull requests, leaving only the
nightly schedule and manual dispatch. The shipped desktop product uses SQLite
only, so the PR check compiled a feature set no other lane builds and cost
10-13 hosted minutes per push without gating anything.

Auto-committed-on: macbook
The storage path filter comment and the self-hosted runner table both
implied MongoDB shared the pull-request lane with the other storage
drivers. Both now state that storage-mongodb.yml runs nightly and on
demand instead, so the docs match the actual trigger.

Auto-committed-on: macbook
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T14:26:59.492387Z e681ecc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 28212dd4-16ab-4963-9593-ce84f717a415
📥 Commits

Reviewing files that changed from the base of the PR and between 4f69bd0 and e681ecc.

📒 Files selected for processing: 3
  • .github/ci-paths-filter.yml
  • .github/workflows/storage-mongodb.yml
  • docs/ci-self-hosted.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The MongoDB storage workflow no longer runs on pull requests. Its nightly schedule and manual dispatch remain. The CI filter comment and self-hosted CI documentation now describe those runs.

Changes: MongoDB workflow triggers

Layer / File(s) Summary
Update MongoDB workflow triggers
.github/workflows/storage-mongodb.yml, .github/ci-paths-filter.yml, docs/ci-self-hosted.md
The workflow no longer has pull request triggers or path filters. The filter comment and lane documentation describe the nightly and manual runs.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: graycyrus

Merge Risk: ⚪ Minimal · up to e681e

MongoDB checks will run nightly or on demand rather than on pull requests, as intended. No issue identified here prevents merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing MongoDB runs from every pull request and retaining nightly execution.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the nightly run,
Then taps dispatch when work is done.
No pull request will start the flow,
The notes now say what schedules show.
I nibble carrots, pleased to see,
Clear workflow notes for all to read.

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e681ecc588

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# never holds up the PR lanes.
# - nightly on main, so a driver regression is caught within a day;
# - on demand (`workflow_dispatch`), e.g. for a PR that changes a driver.
# It does not run on pull requests. The shipped desktop product uses SQLite

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the public storage CI guide

After this trigger removal, docs/gitbooks/en/developing/architecture/storage.md:181 still tells contributors that this workflow runs on pull requests touching storage paths. That is now false and can lead maintainers to treat MongoDB changes as PR-tested when they actually require a manual dispatch or the nightly run; update the canonical public guide along with this behavior change.

AGENTS.md reference: AGENTS.md:L27-L28

Useful? React with 👍 / 👎.

@tinysweeper

tinysweeper Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 5 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: e681ecc588d3
Updated: 2026-10-18T15:15:56Z

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 1 Resolved findings 0
Configuration 2 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 3 files; 1 finding. _The code index is behind this pull request (indexed at `e5e6dace5665`), so retrieved context may be out of date._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 2 files; 0 findings. 1 file was not security-reviewed: docs/ci-self-hosted.md (prose or tabular data). _The code index is behind this pull request (indexed at `e5e6dace5665`), so retrieved context may be out of date._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The description matches the diff: it removes the `pull_request` trigger (and its `paths` list) from `.github/workflows/storage-mongodb.yml`, leaving `schedule` and `workflow_dispatch`, and updates the two comments that claimed the workflow runs on pull requests (`storage` area comment in `.github/ci-paths-filter.yml` and the `storage-drivers` row in `docs/ci-self-hosted.md`). No job, step, target or permission changes alongside it, and nothing in the diff contradicts the body's claims. The trigger removal is a deliberate, disclosed coverage reduction for the PR lanes, so I found no reportable defect. _The code index is behind this pull request (indexed at `e5e6dace5665`), so retrieved context may be out of date._
Evidence and run details
  • Models: ladder/vectors-oai3, deepseek-v4.1-flash
  • Spend: $0.009209
  • Tokens: 240364 input · 32409 output · 125952 cached · 253 embedding
Head State Pass summary
e681ecc588d3 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 2026-10-18T15:15:56Z)

tinysweeper 0.1.2

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0092 · 240,364 in / 32,409 out · 125,952 cached (52%) · ladder/vectors-oai3, deepseek-v4.1-flash · 253 embedded
critique:    $0.0019 · 120,294 in / 16,303 out · 75,776 cached (63%)  · deepseek-v4.1-flash
security:    $0.0036 · 87,875 in  / 5,507 out  · 30,080 cached (34%)  · deepseek-v4.1-flash
description: $0.0032 · 29,201 in  / 8,000 out  · 18,048 cached (62%)  · deepseek-v4.1-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 18, 2026
@senamakel
senamakel merged commit 9d8d4d8 into tinyhumansai:main Oct 18, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant